Fix non-functional bsdinstall services dialog
ClosedPublic
Actions

Authored by dim on Aug 1 2016, 6:35 PM.

Details

Reviewers

robak
allanjude

Commits

rS303749: MFC r303631:
rS303631: Fix non-functional bsdinstall services dialog.

Summary

In https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=211506, I described
how the 11.0-BETA3 installer does not seem to respect any of the
checkboxes in the "Choose the services you would like to be started at
boot" dialog.

This is caused by the bsdinstall/scripts/hardening script, which
implements the new hardening options dialog. The script starts by
overwriting the previously written rc.conf.services file:

echo -n > $BSDINSTALL_TMPETC/rc.conf.services

which is obviously incorrect. It should clear out rc.conf.hardening
instead.

This fix should go to stable/11 ASAP, if re@ agrees.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dim updated this revision to Diff 18941.Aug 1 2016, 6:35 PM

dim retitled this revision from to Fix non-functional bsdinstall services dialog.

dim updated this object.

dim edited the test plan for this revision. (Show Details)

dim added reviewers: robak, allanjude.

dim added subscribers: delphij, gjb, hrs, kib.

Herald added a subscriber: imp. · View Herald TranscriptAug 1 2016, 6:35 PM

Good catch. Thanks for finding this and fixing it

This revision is now accepted and ready to land.Aug 1 2016, 6:38 PM

Closed by commit rS303631: Fix non-functional bsdinstall services dialog. (authored by dim). · Explain WhyAug 1 2016, 7:49 PM

This revision was automatically updated to reflect the committed changes.

That's an obvious mistake, thanks for the fix!

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

bsdinstall/

scripts/

hardening

2 lines

Diff 18943

View Options

head/usr.sbin/bsdinstall/scripts/hardening

Fix non-functional bsdinstall services dialogClosedPublicActions