Allow suppression of --no-fatal-warnings.
AbandonedPublic
Actions

Authored by jonathan on Jul 22 2016, 9:59 PM.

Details

Reviewers

brooks
bapt
bdrewery
rwatson

Summary

When building with an external toolchain whose linker doesn't support the
--no-fatal-warnings flag, we need a mechanism to suppress it. This mechanism
takes the form of a new make variable, LD_NO_FATAL_WARNS. If it is not set,
it defaults to --Wl,--no-fatal-warnings as now. However, it can be defined
in src.conf, at the command line, etc., to be the empty string.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4586
Build 4639: arc lint + arc unit

Event Timeline

jonathan updated this revision to Diff 18694.Jul 22 2016, 9:59 PM

jonathan retitled this revision from to Allow suppression of --no-fatal-warnings..

jonathan updated this object.

jonathan edited the test plan for this revision. (Show Details)

jonathan added reviewers: bapt, rwatson, bdrewery, brooks.

Herald added subscribers: emaste, imp. · View Herald TranscriptJul 22 2016, 9:59 PM

Of course, if we wanted to ignore the --no-fatal-warnings flag altogether, we could just do:

.if !defined(LD_FATAL_WARNINGS) || ${LD_FATAL_WARNINGS} != "no"
SOLINKOPTS+=        -Wl,---fatal-warnings
.endif

However, I wouldn't want to presume that we want to do that...

This seems to have been obviated by rS303274.

Revision Contents
Changeset List

Path

Size

share/

mk/

bsd.lib.mk

4 lines

Diff 18694

View Options

Allow suppression of --no-fatal-warnings.AbandonedPublicActions