Page MenuHomeFreeBSD

hyperv/vmbus: Cleanup channel sending
ClosedPublic

Authored by sepherosa_gmail.com on Jul 11 2016, 3:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Sep 19, 12:21 PM
Unknown Object (File)
Tue, Sep 15, 3:04 PM
Unknown Object (File)
Tue, Sep 15, 3:04 PM
Unknown Object (File)
Sun, Sep 6, 9:23 PM
Unknown Object (File)
Wed, Sep 2, 6:50 AM
Unknown Object (File)
Thu, Aug 27, 2:49 PM
Unknown Object (File)
Mon, Aug 24, 8:09 PM
Unknown Object (File)
Aug 20 2026, 11:58 AM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sepherosa_gmail.com retitled this revision from to hyperv/vmbus: Cleanup channel sending.
sepherosa_gmail.com updated this object.
sepherosa_gmail.com edited the test plan for this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.
head/sys/dev/hyperv/vmbus/hv_channel.c
632

Since you are already modifying this code, I would just use bool here (because it's shorter).

636

All of the above should be size_t, and constified AFAICT (or at least const unsigned int).

649

Adding this padding here is very ugly. Shouldn't the padding be added by hv_ring_buffer_write automatically? It seems open-coding this for every caller of hv_ring_buffer_write is very inefficient.

654

return (error);