Page MenuHomeFreeBSD

hyperv/vmbus: Cleanup channel sending
ClosedPublic

Authored by sepherosa_gmail.com on Jul 11 2016, 3:42 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 2, 11:16 AM
Unknown Object (File)
Thu, Nov 27, 8:58 PM
Unknown Object (File)
Thu, Nov 27, 2:01 AM
Unknown Object (File)
Tue, Nov 25, 10:58 PM
Unknown Object (File)
Sat, Nov 22, 8:02 PM
Unknown Object (File)
Fri, Nov 21, 6:58 AM
Unknown Object (File)
Fri, Nov 21, 1:08 AM
Unknown Object (File)
Fri, Nov 21, 1:08 AM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sepherosa_gmail.com retitled this revision from to hyperv/vmbus: Cleanup channel sending.
sepherosa_gmail.com updated this object.
sepherosa_gmail.com edited the test plan for this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.
head/sys/dev/hyperv/vmbus/hv_channel.c
632

Since you are already modifying this code, I would just use bool here (because it's shorter).

636

All of the above should be size_t, and constified AFAICT (or at least const unsigned int).

649

Adding this padding here is very ugly. Shouldn't the padding be added by hv_ring_buffer_write automatically? It seems open-coding this for every caller of hv_ring_buffer_write is very inefficient.

654

return (error);