Page MenuHomeFreeBSD

hyperv/vmbus: Cleanup channel sending
ClosedPublic

Authored by sepherosa_gmail.com on Jul 11 2016, 3:42 AM.
Tags
None
Referenced Files
F161376779: D7178.id18262.diff
Fri, Jul 3, 6:27 AM
F161363669: D7178.id18455.diff
Fri, Jul 3, 4:21 AM
Unknown Object (File)
Thu, Jul 2, 4:42 AM
Unknown Object (File)
Mon, Jun 15, 12:21 PM
Unknown Object (File)
Mon, Jun 15, 12:20 PM
Unknown Object (File)
Mon, Jun 15, 12:20 PM
Unknown Object (File)
May 12 2026, 4:03 PM
Unknown Object (File)
May 11 2026, 8:14 AM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sepherosa_gmail.com retitled this revision from to hyperv/vmbus: Cleanup channel sending.
sepherosa_gmail.com updated this object.
sepherosa_gmail.com edited the test plan for this revision. (Show Details)
This revision was automatically updated to reflect the committed changes.
head/sys/dev/hyperv/vmbus/hv_channel.c
632

Since you are already modifying this code, I would just use bool here (because it's shorter).

636

All of the above should be size_t, and constified AFAICT (or at least const unsigned int).

649

Adding this padding here is very ugly. Shouldn't the padding be added by hv_ring_buffer_write automatically? It seems open-coding this for every caller of hv_ring_buffer_write is very inefficient.

654

return (error);