Use correct flag when cleaning up pfsync state
ClosedPublic
Actions

Authored by bz on Jun 23 2016, 4:32 PM.

Details

Reviewers

kp
gnn

Commits

rS302157: PFSTATE_NOSYNC goes onto state_flags, not sync_state;
rS302143: PFSTATE_NOSYNC goes onto state_flags, not sync_state;

Summary

PFSTATE_NOSYNC goes onto state_flags, not sync_state;
This prevents: panic: pfsync_delete_state: unexpected sync state 8

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bz updated this revision to Diff 17819.Jun 23 2016, 4:32 PM

bz retitled this revision from to Use correct flag when cleaning up pfsync state.

bz updated this object.

bz edited the test plan for this revision. (Show Details)

bz added reviewers: gnn, kp.

bz set the repository for this revision to rS FreeBSD src repository - subversion.

bz added a subscriber: network.

Herald added a subscriber: imp. · View Herald TranscriptJun 23 2016, 4:32 PM

Just add more context

Closed by commit rS302143: PFSTATE_NOSYNC goes onto state_flags, not sync_state; (authored by bz). · Explain WhyJun 23 2016, 4:36 PM

This revision was automatically updated to reflect the committed changes.

bz mentioned this in rS302143: PFSTATE_NOSYNC goes onto state_flags, not sync_state;.

Ack, obviously correct.

Strangely a Dxxxx in the commit message now also closes things ... nice ... and unexpected.

Closed by commit rS302157: PFSTATE_NOSYNC goes onto state_flags, not sync_state; (authored by bz). · Explain WhyJun 23 2016, 9:42 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

netpfil/

pf/

pf_ioctl.c

2 lines

Diff 17835

View Options

head/sys/netpfil/pf/pf_ioctl.c

Use correct flag when cleaning up pfsync stateClosedPublicActions