Page MenuHomeFreeBSD
Differential D6942

Use correct flag when cleaning up pfsync state
ClosedPublic
Actions

Authored by bz on Jun 23 2016, 4:32 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 2, 3:25 AM
Unknown Object (File)
Tue, Mar 31, 1:41 PM
Unknown Object (File)
Mon, Mar 30, 9:08 PM
Unknown Object (File)
Mon, Mar 30, 8:16 AM
Unknown Object (File)
Fri, Mar 20, 4:09 AM
Unknown Object (File)
Tue, Mar 17, 7:47 AM
Unknown Object (File)
Mon, Mar 16, 6:42 AM
Unknown Object (File)
Mon, Mar 16, 6:34 AM
View All Files
Subscribers
imp
network

Details

Reviewers
kp
gnn
Commits
rS302157: PFSTATE_NOSYNC goes onto state_flags, not sync_state;
rS302143: PFSTATE_NOSYNC goes onto state_flags, not sync_state;
Summary

PFSTATE_NOSYNC goes onto state_flags, not sync_state;
This prevents: panic: pfsync_delete_state: unexpected sync state 8

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz updated this revision to Diff 17819.Jun 23 2016, 4:32 PM
bz retitled this revision from to Use correct flag when cleaning up pfsync state.
bz updated this object.
bz edited the test plan for this revision. (Show Details)
bz added reviewers: gnn, kp.
bz set the repository for this revision to rS FreeBSD src repository - subversion.
bz added a subscriber: network.
Herald added a subscriber: imp. · View Herald TranscriptJun 23 2016, 4:32 PM
bz updated this revision to Diff 17820.Jun 23 2016, 4:33 PM
bz removed rS FreeBSD src repository - subversion as the repository for this revision.

Just add more context

Closed by commit rS302143: PFSTATE_NOSYNC goes onto state_flags, not sync_state; (authored by bz). · Explain WhyJun 23 2016, 4:36 PM
This revision was automatically updated to reflect the committed changes.
bz mentioned this in rS302143: PFSTATE_NOSYNC goes onto state_flags, not sync_state;.
kp edited edge metadata.Jun 23 2016, 7:47 PM

Ack, obviously correct.

bz reopened this revision.Jun 23 2016, 8:59 PM

Strangely a Dxxxx in the commit message now also closes things ... nice ... and unexpected.

Closed by commit rS302157: PFSTATE_NOSYNC goes onto state_flags, not sync_state; (authored by bz). · Explain WhyJun 23 2016, 9:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
netpfil/
pf/
2 lines

Diff 17835

View Options

head/sys/netpfil/pf/pf_ioctl.c

Loading...