Page MenuHomeFreeBSD

Make TCP shutdown more conditional
ClosedPublic

Authored by bz on Jun 22 2016, 12:37 PM.
Tags
None
Referenced Files
F82145593: D6923.id17782.diff
Thu, Apr 25, 10:34 PM
F82145586: D6923.id17761.diff
Thu, Apr 25, 10:34 PM
F82145453: D6923.id.diff
Thu, Apr 25, 10:32 PM
F82145420: D6923.diff
Thu, Apr 25, 10:32 PM
Unknown Object (File)
Mar 16 2024, 11:26 PM
Unknown Object (File)
Feb 11 2024, 9:51 PM
Unknown Object (File)
Jan 2 2024, 12:12 PM
Unknown Object (File)
Jan 1 2024, 3:41 PM
Subscribers

Details

Summary

Check the V_tcbinfo.ipi_count to hit 0 before doing the full TCP cleanup.
That way timers can finish cleanly and we do not gamble with a DELAY().

Note: we still sleep initially for code simplicity. VNET teardown is a slow path;
if someone wants to move this and make the pause conditional on the value of n, then feel free.
I found the tcpdes pause to be helpful when looking at ps (where I regularly saw it).

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bz retitled this revision from to Make TCP shutdown more conditional.
bz updated this object.
bz edited the test plan for this revision. (Show Details)
bz added a reviewer: gnn.
bz set the repository for this revision to rS FreeBSD src repository - subversion.
bz added a subscriber: network.
jtl added a reviewer: jtl.
jtl added a subscriber: jtl.

Looks like a great change. Thanks for your work!

This revision is now accepted and ready to land.Jun 22 2016, 12:40 PM
gnn edited edge metadata.
This revision was automatically updated to reflect the committed changes.