Page MenuHomeFreeBSD

audio/cantata: Update to 2.0.1
ClosedPublic

Authored by woodsb02 on Jun 14 2016, 7:21 AM.
Tags
Referenced Files
Unknown Object (File)
Mar 7 2024, 2:42 PM
Unknown Object (File)
Mar 7 2024, 9:07 AM
Unknown Object (File)
Dec 20 2023, 2:02 AM
Unknown Object (File)
Dec 13 2023, 3:15 PM
Unknown Object (File)
Dec 12 2023, 11:44 PM
Unknown Object (File)
Dec 12 2023, 11:51 AM
Unknown Object (File)
Dec 12 2023, 2:49 AM
Unknown Object (File)
Dec 11 2023, 2:04 PM
Subscribers

Details

Reviewers
tcberner
adamw
koobs
rakuco
mat
Group Reviewers
kde
Summary

audio/cantata: Update to 2.0.1

  • Add USE_QT5=sql sql-sqlite3_run [1]
  • Remove USE_KDE4=oxygen - only required if cmake flag ENABLE_KDE is set
  • Add new options:
    • VLC, QT5 - for MPD HTTP streams playback.
    • PROXY - proxy configuration support.
    • NLS - native language support.
  • Regroup / improve descriptions / add dependencies for all options.
  • Use libebur128 from ports instead of a bundled one (VLC / QT5 options only).

Changes this release:

https://github.com/CDrummond/cantata/blob/v2.0.1/ChangeLog

[1] https://github.com/CDrummond/cantata/blob/v2.0.1/ChangeLog#L34

This update also allows audio/cantata to build against ffmpeg 3.0.x
(when the FFMPEG and TAGLIB options are enabled).
The ports tree currently still has multimedia/ffmepg at version 2.8.7,
however this update is backwards compatible with ffmpeg 2.8.7. The
update of multimedia/ffmpeg to 3.0.x branch is waiting for ports which
depend on it to successfully build with the newer version of ffmpeg.

PR: 209095
Submitted by: avos

Test Plan

poudriere testport audio/cantata

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 4228
Build 4272: arc lint + arc unit

Event Timeline

woodsb02 retitled this revision from to audio/cantata: Update to 2.0.1.
woodsb02 updated this object.
woodsb02 edited the test plan for this revision. (Show Details)
woodsb02 added reviewers: adamw, mat, koobs.
woodsb02 added a subscriber: avos.

Looks good, as with all ports with many options, but very few enabled by default, make sure that the vast majority of people will not need to rebuild with more options enabled to be able to use it.

As per comment from mat, make sure that options which are enabled by default
are sufficient such that the vast majority of people will not need to rebuild
with more options enabled to be able to use it.

I have decided to go with those options which are enabled by default in the
CMakeLists.txt file. This adds the following options to the default build:

  • CDDB
  • CDPARANOIA
  • FFMPEG
  • MPG123
  • MTP
  • MUSICBRAINZ
  • VLC

Whilst this may add a few additional dependencies, the main use case for cantata
is on desktop systems for multimedia playback, so most systems will tend to have
these dependencies already installed.

tcberner edited edge metadata.

I'm not quite sure still whether "INSTALLS_ICONS" is actually needed.

But apart from that, it seemed fine when I tested the original patch from the pr.

This revision is now accepted and ready to land.Jun 14 2016, 5:59 PM

I have decided to go with those options which are enabled by default in the
CMakeLists.txt file. This adds the following options to the default build:

Oh, yes, upstream defaults are a good basis for default options, yes, should have mentioned that :-)

woodsb02 edited edge metadata.

As suggested by Tobias, INSTALLS_ICONS=yes is not required as this is a QT
application (not GTK/GNOME).

This revision now requires review to proceed.Jun 14 2016, 9:35 PM
mat edited edge metadata.

Oh, and if the maintainer is ok with it, I'm ok too.

This revision is now accepted and ready to land.Jun 14 2016, 10:10 PM