Page MenuHomeFreeBSD

pf: Filter on and set vlan PCP values
ClosedPublic

Authored by kp on Jun 9 2016, 1:11 PM.

Details

Summary

Adopt the OpenBSD syntax for setting and filtering on VLAN PCP values.
This introduces two new keywords: 'set prio' to set the PCP value, and 'prio' to
filter on it.

Obtained (mostly) from: OpenBSD

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kp retitled this revision from to pf: Filter on and set vlan PCP values.
kp updated this object.
kp edited the test plan for this revision. (Show Details)
kp added reviewers: loos, araujo.
kp set the repository for this revision to rS FreeBSD src repository - subversion.
share/man/man5/pf.conf.5
1867 ↗(On Diff #17462)

Since the 'number' parameter is not optional, is there a reason it is enclosed in angle quotes?

share/man/man5/pf.conf.5
1867 ↗(On Diff #17462)

No, other that that's what OpenBSD have.

It seems to be a pattern in the pf.conf man page though. See for example 'label' and 'priority'.
I'd be inclined to keep it, if only to be consistent. If we want to change it I'd change all of them (in a separate commit).

allanjude edited edge metadata.

Man page looks good to me

This revision is now accepted and ready to land.Jun 10 2016, 3:02 PM

Do you intend to try and commit this to head before the freeze? It functionally looks the same as D801 which was also accepted by adrian and gnn, but with slightly different syntax.

Do you intend to try and commit this to head before the freeze? It functionally looks the same as D801 which was also accepted by adrian and gnn, but with slightly different syntax.

Hopefully, yes.
I'd like loos@ to take a look at it too before submitting it to re@.

You're quite right that the functionality is mostly the same. The main advantage of this patch is that the syntax matches that in OpenBSD.

araujo edited edge metadata.

You should send it to re@ and we can have the full feature on 11-RELEASE.
The code is pretty much the same as we had before.

So, there is not that much to review here.

Best,

This revision was automatically updated to reflect the committed changes.