Create a get_id pci and pcib interface.

[andrew]

Summary

Add a new get_id interfae to pci and pcib. This will allow us to:

1. Detect failures.
2. Get different PCI IDs.

For 1. the interface returns an int to signal an error. The ID is
returned at a uintptr_t * argument.

For 2. there is a type argument that allows selecting the ID type.
This only specifies a single type, however a MSI type will be added
to handle the need to find the ID the hardware passes to hte GICv3
interrupt controller.

D6227 will be updated to work with this interface.

[andrew]

Fix the return type for pcib_get_id

[andrew]

Fix the check in pcib_get_id

[jhb]

I was going to suggest just naming the new methods 'get_rid' as well, but it does seem like we MFC'd get_rid to stable/10 which is unfortunate. OTOH, I doubt very few things use the API in 10 as SRIOV wasn't MFC'd to 10. I'd rather just fix the API and not support the old one if we can at all help it.

sys/dev/pci/pcivar.h

274 ↗

(On Diff #16132)

I would suggest using an enum as I used for bus_get_cpus(), it's a bit nicer in the debugger.

[andrew]

Update based on feedback

[andrew]

Fix the build, enum pci_id_type needs to be defined before pci_if.h

[rstone]

share/man/man9/pci.9

371 ↗

(On Diff #16149)

it actually stands for "routing identifier"

[jhb]

share/man/man9/pci.9

101 ↗

(On Diff #16149)

The enum needs a variable name ("enum pci_id_type type" or some such)

371 ↗

(On Diff #16149)

Oops, my fault. I gave andrew the wrong answer on IRC.

[andrew]

Fix the manpage