Make this code position independent

[emaste]

Summary

Doing a buildworld of freebsd with lld found only this case where a rw text segment would have been required.

[davide]

LGTM. Colin?

[rafael.espindola_gmail.com]

ping. Note that I don't have commit access.

[davide]

@delphij , @cperciva (or anybody else from security) can you please sign-off this one before it gets in?

[emaste]

• Avoid GOT for non-PIC object
• Just use . instead of a specific label

Submitted by: @kib

[emaste]

(And, rename crypt586.s to crypt586.S)

[emaste]

@kib pointed out this comes from crypto/openssl/crypto/des/asm/crypt586.pl.

As of rS109998 crypt586.pl has:

sub fcrypt_body
        {
        local($name,$do_ip)=@_;

        &function_begin($name);

        &comment("");
        &comment("Load the 2 words");
        $trans="ebp";

        &xor(   $L,     $L);
        &xor(   $R,     $R);

        # PIC-ification:-)
        &picmeup("edx","DES_SPtrans");
        #if ($cpp)      { &picmeup("edx","DES_SPtrans");   }
        #else           { &lea("edx",&DWP("DES_SPtrans")); }
        &push("edx");   # becomes &swtmp(1)
        #
        &mov($trans,&wparam(1)); # reloaded with DES_SPtrans in D_ENCRYPT      

        &push(&DWC(25)); # add a variable

but the generated version in this review was added in rS95967 prior to that change.

[emaste]

Reverted in rS299172 as these files are actually generated output.

Proposal in D6237 to add a "Generated from" comment so that it's more clear in the future that they should not be edited directly.

We'll need to find a different way to address the .text relocation.