Page MenuHomeFreeBSD

Add error return value to PIC_CONFIG interface on ARM64
AbandonedPublic

Authored by mst_semihalf.com on Apr 27 2016, 4:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 12:02 AM
Unknown Object (File)
Nov 13 2023, 1:32 PM
Unknown Object (File)
Nov 5 2023, 2:16 AM
Unknown Object (File)
Nov 4 2023, 10:19 PM
Unknown Object (File)
Nov 3 2023, 8:11 PM
Unknown Object (File)
Oct 25 2023, 9:03 AM
Unknown Object (File)
Jun 24 2023, 8:51 PM
Unknown Object (File)
Mar 6 2023, 9:18 PM
Subscribers

Details

Reviewers
zbb
andrew
imp
Summary

PIC_CONFIG now returns an error value. It is passed over as the return value of BUS_CONFIG_INTR method.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

mst_semihalf.com retitled this revision from to Add error return value to PIC_CONFIG interface on ARM64.
mst_semihalf.com updated this object.
mst_semihalf.com edited the test plan for this revision. (Show Details)
mst_semihalf.com added reviewers: andrew, zbb.
mst_semihalf.com set the repository for this revision to rS FreeBSD src repository - subversion.
mst_semihalf.com added a subscriber: arm64.
andrew requested changes to this revision.Apr 27 2016, 4:59 PM
andrew edited edge metadata.

I am close to switching to intrng & removing this interface. It's already working with the GICv2, GICv2m, and GICv3. I'm currently working on the GICv3 ITS. As such this interface will be removed soon, I would expect to remove it before 11.0-RELEASE.

This will also affect D6127, D6128, D6129, D6130, D6131, and D6132.

This revision now requires changes to proceed.Apr 27 2016, 4:59 PM

I am close to switching to intrng & removing this interface. It's already working with the GICv2, GICv2m, and GICv3. I'm currently working on the GICv3 ITS. As such this interface will be removed soon, I would expect to remove it before 11.0-RELEASE.

This will also affect D6127, D6128, D6129, D6130, D6131, and D6132.

What changes do you propose to ease the transition while still getting the patches - or some of them - committed? I think that PIC_CONFIG implementation (D6129) could be submitted as-is, because there won't be any need to modify it for INTRNG. Obviously we need this method even if bus_config_intr is removed or deprecated. PIC_TRANSLATE_CODE (D6130) would only need a minor change if any, to adjust it to INTRNG. Perhaps some of the other patches would not cause a conflict either. Please correct me if I'm wrong, I only briefly looked at the existing ARM INTRNG code.