tpm: crb: Log cmd failures, correct Pluton mailbox handshake
Needs ReviewPublic
Actions

Authored by kbowling on Mon, Nov 2, 6:53 AM.

Project Tags

None

Referenced Files

	F177050124: D61128.1793770007.diff
	Tue, Nov 3, 5:26 AM

	F177044874: D61128.1793764806.diff
	Tue, Nov 3, 4:00 AM

	F177044805: D61128.1793764745.diff
	Tue, Nov 3, 3:59 AM

	F177024406: D61128.1793743674.diff
	Mon, Nov 2, 10:07 PM

	F176985429: D61128.1793694957.diff
	Mon, Nov 2, 8:35 AM

Subscribers

imp

Details

Reviewers

bz
olivier

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kbowling created this revision.Mon, Nov 2, 6:53 AM

Herald added a subscriber: imp. · View Herald TranscriptMon, Nov 2, 6:53 AM

kbowling requested review of this revision.Mon, Nov 2, 6:53 AM

My FrameWork desktop (AMD RYZEN AI MAX+ 395) is running main-n290446-0974ef03b43f and don’t have this "Log cmd failures", but would you like I test this patch anyway ?

In D61128#1401318, @olivier wrote:

My FrameWork desktop (AMD RYZEN AI MAX+ 395) is running main-n290446-0974ef03b43f and don’t have this "Log cmd failures", but would you like I test this patch anyway ?

It would be good to know if the functional change here causes any new issue or not.

But otherwise need @bz to report the output of this.

So I’ve applied the patch and rebooted.
Then, I’ve ran some tests and didn’t notice a regression

Revision Contents
Changeset List

Path

Size

sys/

dev/

tpm/

tpm_crb.c

76 lines

Diff 191275

View Options

tpm: crb: Log cmd failures, correct Pluton mailbox handshakeNeeds ReviewPublicActions