Page MenuHomeFreeBSD

generic devmap
ClosedPublic

Authored by br on Apr 25 2016, 5:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 20, 10:27 AM
Unknown Object (File)
Wed, Nov 19, 2:08 PM
Unknown Object (File)
Wed, Nov 19, 1:43 PM
Unknown Object (File)
Wed, Nov 19, 5:50 AM
Unknown Object (File)
Wed, Nov 19, 4:44 AM
Unknown Object (File)
Mon, Nov 17, 3:27 AM
Unknown Object (File)
Thu, Nov 13, 8:29 AM
Unknown Object (File)
Tue, Nov 4, 1:48 PM
Subscribers

Details

Reviewers
andrew
imp
ian
Group Reviewers
ARM

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

br retitled this revision from to generic devmap.
br updated this object.
br edited the test plan for this revision. (Show Details)
br added reviewers: andrew, ARM, ian.
imp added a reviewer: imp.
imp added a subscriber: imp.

A couple of minor nits, but overall this looks good to my eye.

sys/arm/versatile/versatile_machdep.c
101

elsewhere, we use the style 'fdt_devmap' to refer to the array. I know you didn't change that from the old code, but this is the only instance of that we have.

sys/kern/subr_devmap.c
33

Do we need the list?

This revision is now accepted and ready to land.Apr 25 2016, 5:17 PM