smsc: Add external PHY support
ClosedPublic
Actions

Authored by emaste on Thu, Oct 15, 1:59 PM.

Project Tags

None

Referenced Files

	F177338298: D60744.1794151117.diff
	Sat, Nov 7, 3:18 PM

	F177312883: D60744.1794123943.diff
	Sat, Nov 7, 7:45 AM

Subscribers

imp

Details

Reviewers

br
gonzo
adrian

Commits

rGdc4c75c9a3c3: smsc: Support external PHY

Summary

SMSC_HW_CFG_PSEL indicates that an external PHY is present. Skip the internal PHY initialization when set and store the ID of the detected PHY.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste requested review of this revision.Thu, Oct 15, 1:59 PM

emaste created this revision.

emaste retitled this revision from smsc: Add external PHY supportSupport external PHY to smsc: Add external PHY support.Thu, Oct 15, 2:04 PM

emaste edited the summary of this revision. (Show Details)

emaste added reviewers: br, gonzo, adrian.

emaste added a parent revision: D60743: smsc: Remove phy address check in smsc_miibus_writereg.

emaste added a child revision: D60745: smsc: Allow 10BASE-T1L/-T1S media.Thu, Oct 15, 2:11 PM

looks ok to me

sys/dev/usb/net/if_smsc.c
1698–1700

This revision is now accepted and ready to land.Thu, Oct 15, 3:07 PM

br added inline comments.Thu, Oct 15, 3:11 PM

sys/dev/usb/net/if_smsc.c
1731–1740

style(9) from br@

This revision now requires review to proceed.Thu, Oct 15, 3:16 PM

emaste added inline comments.Thu, Oct 15, 3:17 PM

sys/dev/usb/net/if_smsc.c
1732

Correct copy-pasteo

br accepted this revision.Thu, Oct 15, 6:10 PM

This revision is now accepted and ready to land.Thu, Oct 15, 6:10 PM

emaste added a parent revision: D60828: smsc: Use read-modify-write to configure LEDs.Sun, Oct 18, 1:07 AM

Closed by commit rGdc4c75c9a3c3: smsc: Support external PHY. · Explain WhyThu, Oct 29, 8:42 AM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rGdc4c75c9a3c3: smsc: Support external PHY.

Herald added a subscriber: imp. · View Herald TranscriptThu, Oct 29, 8:42 AM

Revision Contents
Changeset List

Path

Size

sys/

dev/

usb/

net/

if_smsc.c

39 lines

if_smscreg.h

1 line

Diff 190700

View Options

sys/dev/usb/net/if_smsc.c