Page MenuHomeFreeBSD

smsc: Remove phy address check in smsc_miibus_writereg
Needs ReviewPublic

Authored by emaste on Thu, Oct 15, 1:41 PM.
Tags
None
Referenced Files
F176313765: D60743.diff
Sat, Oct 17, 8:33 PM
Unknown Object (File)
Fri, Oct 16, 9:43 AM
Unknown Object (File)
Fri, Oct 16, 5:53 AM
Unknown Object (File)
Fri, Oct 16, 2:58 AM
Unknown Object (File)
Fri, Oct 16, 2:31 AM
Unknown Object (File)
Thu, Oct 15, 11:59 PM
Unknown Object (File)
Thu, Oct 15, 11:25 PM
Unknown Object (File)
Thu, Oct 15, 11:23 PM
Subscribers
None

Details

Reviewers
gonzo
adrian
Summary
The driver only allowed writes to the expected phy (i.e., sc->sc_phyno),
and reads were never filtered.  sc_phyno is already passed to
mii_attach() as phyloc, so nothing tries to issue MDIO writes to other
addresses and the check is not required.

Remove the check in advance of supporting external PHYs at arbitrary
addresses.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped