Page MenuHomeFreeBSD

Document Source Management Team policies
Needs ReviewPublic

Authored by imp on Sat, Oct 10, 7:57 PM.
Tags
None
Referenced Files
F175670963: D60597.id189501.diff
Mon, Oct 12, 10:11 AM
F175650439: D60597.diff
Mon, Oct 12, 7:05 AM
F175648072: D60597.id.diff
Mon, Oct 12, 6:44 AM
F175646505: D60597.id189501.diff
Mon, Oct 12, 6:32 AM
F175625793: D60597.id189408.diff
Mon, Oct 12, 3:27 AM
F175602186: D60597.diff
Sun, Oct 11, 11:34 PM
F175600844: D60597.id189501.diff
Sun, Oct 11, 11:20 PM
F175579032: D60597.id189408.diff
Sun, Oct 11, 7:45 PM
Subscribers
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

Fill previously empty srcmgr/policies.adoc placeholder with actual
policies documented from srcmgr practice: code review expectations,
compilation requirements, testing expectations, main branch soak
time, commit access principles, bit reclamation timeline, and stable
branch rules.

Update srcmgr/_index.adoc to reflect policies are now complete.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 78026
Build 74909: arc lint + arc unit

Event Timeline

imp requested review of this revision.Sat, Oct 10, 7:57 PM
imp created this revision.
emaste added inline comments.
website/content/en/srcmgr/policies.adoc
14 ↗(On Diff #189408)

"Pre-commit code review"?

18 ↗(On Diff #189408)

We have a discussion of phab vs github in CONTRIBUTING.md as well. I think listing these as preferred/acceptable makes sense here, but we might want to revisit CONTRIBUTING and clarify it a bit.

My take is:

Use Phabricator if any of the following are true:

  • you are a FreeBSD committer
  • you're working closely with one or more FreeBSD committers on some body of work (i.e., you know who is going to land the change)
  • the change is large or controversial

Use GitHub if both are true:

  • you already have a GitHub account (and probably not a Phabricator account)
  • the change is straightforward
44 ↗(On Diff #189408)

We haven't really codified this before?

53 ↗(On Diff #189408)

Thanks for the review ed! Much appreciated.

website/content/en/srcmgr/policies.adoc
14 ↗(On Diff #189408)

Yes. That's a stronger, and better, statement.

18 ↗(On Diff #189408)

I'll bring this in.
There's one other time, though, and that's to test with github's CI. Is that too much detail?

44 ↗(On Diff #189408)

It's in the cross repo policy I just did. I wasn't sure if we needed it here or not. Some of this work is organizational vs writing stuff down we do, but haven't documented.

53 ↗(On Diff #189408)

better framing! Thanks!