Differential D60543

pf: Parse the GETSTATES state id as 64 bits
ClosedPublic
Actions

Authored by rcm on Fri, Oct 9, 6:20 PM.

Project Tags

None

Referenced Files

None

Subscribers

vegeta_tuxpowered.net

Details

Reviewers

Commits

rG54b034b928c0: pf: Parse the GETSTATES state id as 64 bits
rG74d2a0b79ffd: pf: Parse the GETSTATES state id as 64 bits

Summary

The GETSTATES dump sends PF_ST_ID as a u64, but the request parser
reads it as a u32 and rejects an id taken from the dump with EINVAL.
Nothing in base sends PF_ST_ID. Parse and document it as a u64.

Fixes: 2cef62886dc7 ("pf: convert state retrieval to netlink")
MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rcm created this revision.Fri, Oct 9, 6:20 PM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptFri, Oct 9, 6:20 PM

rcm requested review of this revision.Fri, Oct 9, 6:20 PM

That looks correct, but I don't quite follow the commit message. As far as I can tell nothing in userspace ever sends PF_ST_ID.

This revision is now accepted and ready to land.Tue, Oct 13, 2:48 PM

rcm edited the summary of this revision. (Show Details)Tue, Oct 13, 3:02 PM

Good, ship it ;)

In D60543#1391680, @kp wrote:

That looks correct, but I don't quite follow the commit message. As far as I can tell nothing in userspace ever sends PF_ST_ID.

Yeah, nothing in base sends it. Reworded the commit message.

Closed by commit rG74d2a0b79ffd: pf: Parse the GETSTATES state id as 64 bits. · Explain WhyTue, Oct 13, 3:09 PM

This revision was automatically updated to reflect the committed changes.

rcm added a commit: rG74d2a0b79ffd: pf: Parse the GETSTATES state id as 64 bits.

rcm added a commit: rG54b034b928c0: pf: Parse the GETSTATES state id as 64 bits.Thu, Oct 29, 6:45 PM