dhclient: Avoid out-of-bounds reads in check_classless_option()
Needs ReviewPublic
Actions

Authored by markj on Thu, Oct 8, 6:04 PM.

Tags

None

Referenced Files

	F175309803: D60484.id189078.diff
	Fri, Oct 9, 8:50 PM

	F175309489: D60484.diff
	Fri, Oct 9, 8:47 PM

	F175275204: D60484.id189078.diff
	Fri, Oct 9, 3:47 PM

	F175261072: D60484.diff
	Fri, Oct 9, 12:56 PM

	F175261025: D60484.id.diff
	Fri, Oct 9, 12:55 PM

	F175222613: D60484.diff
	Fri, Oct 9, 5:38 AM

Subscribers

imp

Details

Reviewers

None

Group Reviewers

network

Summary

The loop did not verify that the option buffer is large enough before
reading an address.

Reported by: Andrew Griffiths <andrew@calif.io>
MFC after: 2 weeks
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77868
Build 74751: arc lint + arc unit

Event Timeline

markj created this revision.Thu, Oct 8, 6:04 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Oct 8, 6:04 PM

markj requested review of this revision.Thu, Oct 8, 6:04 PM

markj added a child revision: D60485: dhclient: Add some regression tests.

Harbormaster completed remote builds in B77868: Diff 189078.Thu, Oct 8, 6:05 PM

Revision Contents
Changeset List

Path

Size

sbin/

dhclient/

dhclient.c

64 lines

Diff 189078

View Options

dhclient: Avoid out-of-bounds reads in check_classless_option()Needs ReviewPublicActions