Differential D60258

dhclient: export the Captive Portal URI to the script
Needs ReviewPublic
Actions

Authored by bapt on Fri, Oct 2, 8:13 PM.

Tags

None

Referenced Files

	F174413950: D60258.id188494.diff
	Sat, Oct 3, 12:46 AM

	F174413852: D60258.id188508.diff
	Sat, Oct 3, 12:45 AM

	F174410634: D60258.diff
	Sat, Oct 3, 12:19 AM

Subscribers

Details

Reviewers

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77676
Build 74559: arc lint + arc unit

Event Timeline

bapt created this revision.Fri, Oct 2, 8:13 PM

Herald added a subscriber: imp. · View Herald TranscriptFri, Oct 2, 8:13 PM

bapt requested review of this revision.Fri, Oct 2, 8:13 PM

Harbormaster completed remote builds in B77663: Diff 188494.Fri, Oct 2, 8:13 PM

bapt added a parent revision: D60257: dhclient: request the Captive Portal options.Fri, Oct 2, 8:13 PM

bapt added a child revision: D60259: dhclient-script: store the Captive Portal URI.

bapt added a reviewer: emaste.Fri, Oct 2, 8:15 PM

Why does this one need special handling? Worth a comment in the code / commit message.

to name is captive_portal_url instead of captive_portal but yes I can add a comment in the code imho more than in the commit log

add comment in code and commit log

Harbormaster completed remote builds in B77676: Diff 188508.Fri, Oct 2, 9:39 PM

Revision Contents
Changeset List

Path

Size

sbin/

dhclient/

17 lines

Diff 188508

sbin/dhclient/dhclient.c

Loading...