dhclient-script: store the Captive Portal URI
ClosedPublic
Actions

Authored by bapt on Fri, Oct 2, 8:13 PM.

Details

Reviewers

emaste
bcr

Commits

rG0f1ca95d7740: dhclient-script: store the Captive Portal URI

Summary

Write the URI received in DHCP option 114 to
/var/run/captive-portal.IFACE atomically, with the legacy option 160 as
a fallback, and remove the file on EXPIRE and FAIL.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bapt created this revision.Fri, Oct 2, 8:13 PM

Herald added subscribers: ziaee, imp. · View Herald TranscriptFri, Oct 2, 8:13 PM

bapt requested review of this revision.Fri, Oct 2, 8:13 PM

Harbormaster completed remote builds in B77664: Diff 188495.Fri, Oct 2, 8:13 PM

bapt added a parent revision: D60258: dhclient: export the Captive Portal URI to the script.Fri, Oct 2, 8:13 PM

bapt added a reviewer: emaste.Fri, Oct 2, 8:15 PM

OK for the man page part of the change.

This revision is now accepted and ready to land.Sat, Oct 3, 5:43 PM

Can we MFC this? Relnotes?

Closed by commit rG0f1ca95d7740: dhclient-script: store the Captive Portal URI (authored by bapt). · Explain WhyWed, Oct 7, 2:08 PM

This revision was automatically updated to reflect the committed changes.

bapt mentioned this in rG7ba72855939f: dhclient: export the Captive Portal URI to the script.

bapt added a commit: rG0f1ca95d7740: dhclient-script: store the Captive Portal URI.

Thanks for RFC 8910 support in dhclient. Can we count on such an enhancement for rtosld(8)? Are there any ongoing efforts to implement point 2.3 from tis RFC "The Captive-Portal IPv6 RA Option" ?

I have it, but I had no way to test it hence why I haven't pushed, it, do you have a test env for that?

It seems that testing this properly requires relatively modern network equipment that supports the Captive-Portal IPv6 RA Option. On the other hand, net/radvd in the FreeBSD ports tree supports the option, so I should be able to set up a test environment. I will most likely have some time to prepare it and run the tests before the upcoming RIPE 93.