Page MenuHomeFreeBSD

ddb: rework 'reboot' and 'reset' command behaviour
Needs ReviewPublic

Authored by mhorne on Wed, Oct 7, 5:21 PM.
Tags
None
Referenced Files
F175066313: D60445.diff
Thu, Oct 8, 12:33 AM
F175030688: D60445.diff
Wed, Oct 7, 6:34 PM
F175030196: D60445.id188996.diff
Wed, Oct 7, 6:28 PM
Subscribers

Details

Reviewers
jhb
avg
markj
bz
Summary

This is another attempt to addressed the continual fallout from
5644850620ae, which "improved" the ddb reset command by running shutdown
hooks. This has proven to be fragile, generating recursive panics in
some scenarios. Being able to reset the system successfully from a
panicked state is of plain importance.

So, we attempt to find a compromise.

Split the commands as discussed: 'reset' is restored to its old
behavior, the bare essential invocation of cpu_reset(). Meanwhile,
'reboot' will execute the full kern_reboot() path, with shutdown
handlers.

I am omitting backwards compatibility of the \s flag unless requested.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77818
Build 74701: arc lint + arc unit