Page MenuHomeFreeBSD

netinet6: Fix the OSIOCAIFADDR_IN6 handler
Needs ReviewPublic

Authored by markj on Wed, Sep 30, 8:25 PM.
Tags
None
Referenced Files
F174180380: D60184.id188241.diff
Thu, Oct 1, 4:43 AM
F174168836: D60184.diff
Thu, Oct 1, 2:42 AM
F174150957: D60184.id188241.diff
Wed, Sep 30, 11:10 PM
F174150318: D60184.diff
Wed, Sep 30, 11:04 PM

Details

Reviewers
None
Group Reviewers
network
Summary

We cannot simply treat a pointer to struct oin6_aliasreq as a pointer to
struct in6_aliasreq: the latter is larger. In particular, the store to
ifra->ifra_vhid is out of bounds.

Since OSIOCAIFADDR_IN6 does not need to copy data back out, it can
simply use a struct in6_ifaliasreq on the stack.

Reported by: Andrew <xxx.sys@protonmail.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 77536
Build 74419: arc lint + arc unit