Page MenuHomeFreeBSD
Differential D60183

pfctl: print "pass" on nat/rdr/binat rules again
ClosedPublic
Actions

Authored by rcm on Wed, Sep 30, 6:51 PM.
Tags
None
Referenced Files
F174185519: D60183.id.diff
Thu, Oct 1, 5:33 AM
F174185294: D60183.id188235.diff
Thu, Oct 1, 5:31 AM
F174160491: D60183.id188272.diff
Thu, Oct 1, 12:56 AM
F174159679: D60183.id188235.diff
Thu, Oct 1, 12:46 AM
F174157394: D60183.id188240.diff
Thu, Oct 1, 12:18 AM
F174153459: D60183.diff
Wed, Sep 30, 11:35 PM
F174146630: D60183.id188272.diff
Wed, Sep 30, 10:19 PM
F174146326: D60183.id188235.diff
Wed, Sep 30, 10:16 PM
View All 12 Files
Subscribers
farrokhi
glebius
imp
melifaro
vegeta_tuxpowered.net

Details

Reviewers
kp
Commits
rG3171a60de403: pfctl: print "pass" on nat/rdr/binat rules again
Summary

c2d03a920ec7 rewrote the action printing in print_rule() from OpenBSD,
which has no natpass, and dropped the "pass" keyword. A ruleset
loaded from "pfctl -sn" output therefore lost its nat-pass semantics.

Add a parser test covering nat, rdr, rdr log and binat with pass.

Fixes: c2d03a920ec7 ("pfctl: fix anchortypes bounds test")
MFC after: 1 week
Sponsored by: Rubicon Communications, LLC ("Netgate")

Test Plan

Regression test included

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rcm created this revision.Wed, Sep 30, 6:51 PM
Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptWed, Sep 30, 6:51 PM
rcm requested review of this revision.Wed, Sep 30, 6:51 PM
rcm updated this revision to Diff 188240.Wed, Sep 30, 7:48 PM
rcm retitled this revision from pfctl: restore printing of 'pass' on nat/rdr/binat rules to pfctl: print "pass" on nat/rdr/binat rules again.
rcm edited the summary of this revision. (Show Details)

Prefer parser test as per kp@

kp accepted this revision.Wed, Sep 30, 8:28 PM
This revision is now accepted and ready to land.Wed, Sep 30, 8:28 PM
Closed by commit rG3171a60de403: pfctl: print "pass" on nat/rdr/binat rules again (authored by rcm). · Explain WhyWed, Sep 30, 10:03 PM
This revision was automatically updated to reflect the committed changes.
rcm added a commit: rG3171a60de403: pfctl: print "pass" on nat/rdr/binat rules again.

Revision Contents
Changeset List

PathSize
sbin/
pfctl/
5 lines
tests/
files/
5 lines
5 lines
1 line

Diff 188272

View Options

sbin/pfctl/pfctl_parser.c

Loading...
View Options

sbin/pfctl/tests/files/pf1080.in

Loading...
View Options

sbin/pfctl/tests/files/pf1080.ok

Loading...
View Options

sbin/pfctl/tests/pfctl_test_list.inc

Loading...