release: switch the WITH_* knobs to just gating `release` dependencies

[kevans]

Summary

The knobs are useful to have to control what `make release` does by
default, but it's also quite possible to just drive individual targets
if you don't plan to generate the entire set of release images.  Always
including the logic and only attaching the *-release dependencies onto
the `release` target if the relevant WITH_* knobs are set makes a lot of
sense.

Sponsored by:	Klara, Inc.

[cperciva]

When you get to cloudware, my sense is that it's more likely someone will run e.g. make ec2ami-desktop-ufs rather than make cloudware-release.

Perhaps a better solution would be to have the relevant Makefile logic included unconditionally and have the WITH_* flags only control which targets are dependencies of release ?

[kevans]

In D60036#1377406, @cperciva wrote:

When you get to cloudware, my sense is that it's more likely someone will run e.g. make ec2ami-desktop-ufs rather than make cloudware-release.

Perhaps a better solution would be to have the relevant Makefile logic included unconditionally and have the WITH_* flags only control which targets are dependencies of release ?

Sure thing, I like that approach a lot more but I wasn't sure if I'd be able to get buy-in (because I might be overlooking how these were expecting to be used). I will do that instead.

[ziaee]

Can you also update release(7) with the new knobs?

[kevans]

In D60036#1377648, @ziaee wrote:

Can you also update release(7) with the new knobs?

This isn't introducing any new knobs, just imbuing them wth a slightly different meaning that isn't actually incompatible with the currernt verbiage.

[kevans]

Switch gears and just control the release and install dependencies. Convert .WAIT into .ORDER and dcument the pain point that requires it, but call it out of scope for the moment as long as we don't break re@ builds.