Differential D59983

jail: Simplify refcount manipulation routines
AcceptedPublic
Actions

Authored by markj on Thu, Sep 24, 1:52 PM.

Tags

None

Referenced Files

	F173301087: D59983.id.diff
	Fri, Sep 25, 3:02 AM

	F173298335: D59983.id187599.diff
	Fri, Sep 25, 2:40 AM

	F173293774: D59983.diff
	Fri, Sep 25, 1:38 AM

	F173273190: D59983.diff
	Thu, Sep 24, 9:30 PM

	F173257159: D59983.id187599.diff
	Thu, Sep 24, 6:29 PM

	F173251934: D59983.diff
	Thu, Sep 24, 5:32 PM

Subscribers

Details

Reviewers

Group Reviewers

Summary

refcount_acquire() returns the old value, use that to assert that the old value was non-zero.
refcount_release() already asserts that the refcount value is non-zero, so don't bother asserting that again in the jail code.
Use __diagused instead of having separate implementations for INVARIANTS and !INVARIANTS.

No functional change intended.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77273
Build 74156: arc lint + arc unit

Event Timeline

markj created this revision.Thu, Sep 24, 1:52 PM

Herald added subscribers: olce, imp. · View Herald TranscriptThu, Sep 24, 1:52 PM

markj requested review of this revision.Thu, Sep 24, 1:52 PM

Harbormaster completed remote builds in B77273: Diff 187599.Thu, Sep 24, 1:53 PM

markj added a child revision: D59984: jail: Fix a race in prison_deref().Thu, Sep 24, 1:53 PM

I wasn't familiar with __diagused. Yes, this is all cleaner.

This revision is now accepted and ready to land.Thu, Sep 24, 5:26 PM

Revision Contents
Changeset List

Path

Size

sys/

kern/

37 lines

Diff 187599

sys/kern/kern_jail.c

Loading...