Page MenuHomeFreeBSD

posixshm: Fix a double unlock in shm_partial_page_invalidate()
ClosedPublic

Authored by markj on Mon, Sep 21, 4:43 PM.
Tags
None
Referenced Files
F173298539: D59877.id187346.diff
Fri, Sep 25, 2:42 AM
F173297959: D59877.id187511.diff
Fri, Sep 25, 2:36 AM
F173252030: D59877.id187511.diff
Thu, Sep 24, 5:33 PM
F173233104: D59877.id187346.diff
Thu, Sep 24, 1:14 PM
F173186256: D59877.id.diff
Thu, Sep 24, 4:25 AM
Unknown Object (File)
Thu, Sep 24, 3:24 AM
Unknown Object (File)
Thu, Sep 24, 2:41 AM
Unknown Object (File)
Wed, Sep 23, 7:12 PM
Subscribers

Details

Summary

For some reason, shm_partial_page_invalidate() unlocks the object upon
an error, but its callers don't expect this. Don't do any special error
handling. Keep the subroutine anyway since the name is a bit clearer
than vm_page_grab_zero_partial().

While here, normalize the object pointer used for locking in
shm_deallocate().

Fixes: 454bc887f250 ("uipc_shm: Implements fspacectl(2) support")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable