Differential D59873

sound: Retire the version constants
AcceptedPublic
Actions

Authored by christos on Mon, Sep 21, 12:11 PM.

Tags

None

Referenced Files

	F172900660: D59873.id187327.diff
	Mon, Sep 21, 11:05 PM

	F172893629: D59873.diff
	Mon, Sep 21, 9:58 PM

	F172884580: D59873.diff
	Mon, Sep 21, 8:22 PM

	F172851243: D59873.id187327.diff
	Mon, Sep 21, 2:21 PM

Subscribers

Details

Reviewers

markj
emaste
kib
andrew
manu

Summary

They exist only to fill in MODULE_DEPEND() and MODULE_VERSION(), and
every consumer passed the same value for all three, so the version
range never did anything. Use 1, like the rest of the tree does.

MFC after: 1 week
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77135
Build 74018: arc lint + arc unit

Event Timeline

christos created this revision.Mon, Sep 21, 12:11 PM

Herald added a reviewer: andrew. · View Herald TranscriptMon, Sep 21, 12:11 PM

Herald added a reviewer: manu. · View Herald Transcript

Herald added a subscriber: imp. · View Herald Transcript

christos requested review of this revision.Mon, Sep 21, 12:11 PM

Harbormaster completed remote builds in B77135: Diff 187327.Mon, Sep 21, 12:11 PM

christos edited the summary of this revision. (Show Details)Mon, Sep 21, 12:12 PM

christos retitled this revision from sound: Retire the SOUND_*VER macros to sound: Retire the version constants.

emaste added inline comments.Mon, Sep 21, 3:18 PM

sys/dev/sound/pcm/sound.c
745	I guess this could be an issue if folks have out-of-tree modules.

christos added inline comments.Mon, Sep 21, 4:59 PM

sys/dev/sound/pcm/sound.c
745	Theoretically yes, but I haven't found any out-of-tree driver which depends on sound(4)'s versioning, so if there is any that I missed, I think it's worth just doing a rebuild. sound(4) versions have been unmaintained for long and there is no use for them.

kib accepted this revision.Mon, Sep 21, 6:23 PM

This revision is now accepted and ready to land.Mon, Sep 21, 6:23 PM

emaste accepted this revision.Mon, Sep 21, 6:24 PM

Revision Contents
Changeset List

Path

Size

sys/

arm/

allwinner/

2 lines

broadcom/

bcm2835/

bcm2835_audio.c

2 lines

freescale/

imx/

2 lines

vybrid/

2 lines

dev/

firewire/

2 lines

2 lines

sound/

2 lines

macio/

2 lines

2 lines

pci/

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

hda/

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

2 lines

pcm/

6 lines

2 lines

usb/

2 lines

2 lines

Diff 187327

sys/arm/allwinner/a10_codec.c

Loading...

sys/arm/broadcom/bcm2835/bcm2835_audio.c

Loading...

sys/arm/freescale/imx/imx6_ssi.c

Loading...

sys/arm/freescale/vybrid/vf_sai.c

Loading...

sys/dev/firewire/fwisound.c

Loading...

sys/dev/firewire/fwisound_pcm.c

Loading...

sys/dev/sound/dummy.c

Loading...

sys/dev/sound/macio/davbus.c

Loading...

sys/dev/sound/macio/i2s.c

Loading...

sys/dev/sound/pci/als4000.c

Loading...

sys/dev/sound/pci/atiixp.c

Loading...

sys/dev/sound/pci/cmi.c

Loading...

sys/dev/sound/pci/cs4281.c

Loading...

sys/dev/sound/pci/csa.c

Loading...

sys/dev/sound/pci/csamidi.c

Loading...

sys/dev/sound/pci/csapcm.c

Loading...

sys/dev/sound/pci/emu10k1.c

Loading...

sys/dev/sound/pci/emu10kx-midi.c

Loading...

sys/dev/sound/pci/emu10kx-pcm.c

Loading...

sys/dev/sound/pci/envy24.c

Loading...

sys/dev/sound/pci/envy24ht.c

Loading...

sys/dev/sound/pci/es137x.c

Loading...

sys/dev/sound/pci/fm801.c

Loading...

sys/dev/sound/pci/hda/hdaa.c

Loading...

sys/dev/sound/pci/hdsp-pcm.c

Loading...

sys/dev/sound/pci/hdspe-pcm.c

Loading...

sys/dev/sound/pci/ich.c

Loading...

sys/dev/sound/pci/maestro3.c

Loading...

sys/dev/sound/pci/neomagic.c

Loading...

sys/dev/sound/pci/solo.c

Loading...

sys/dev/sound/pci/spicds.c

Loading...

sys/dev/sound/pci/t4dwave.c

Loading...

sys/dev/sound/pci/via8233.c

Loading...

sys/dev/sound/pci/via82c686.c

Loading...

sys/dev/sound/pci/vibes.c

Loading...

sys/dev/sound/pcm/sound.h

Loading...

sys/dev/sound/pcm/sound.c

Loading...

sys/dev/sound/usb/uaudio.c

Loading...

sys/dev/sound/usb/uaudio_pcm.c

Loading...