Page MenuHomeFreeBSD
Differential D59719

libkvm: fix reading ppc64(le) minidumps
ClosedPublic
Actions

Authored by mchoo on Wed, Sep 16, 3:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 8, 10:46 PM
Unknown Object (File)
Tue, Oct 6, 9:02 AM
Unknown Object (File)
Mon, Oct 5, 11:05 PM
Unknown Object (File)
Mon, Oct 5, 7:36 PM
Unknown Object (File)
Mon, Oct 5, 11:10 AM
Unknown Object (File)
Sun, Oct 4, 8:51 PM
Unknown Object (File)
Sun, Oct 4, 8:51 PM
Unknown Object (File)
Sun, Oct 4, 6:05 PM
View All 38 Files
Subscribers
imp
olce

Details

Reviewers
adrian
jhibbits
ivy
jhb
Group Reviewers
PowerPC
Commits
rG382f26f264bd: libkvm: route powerpc64 minidumps to minidump backend
rGea3004b24770: libkvm: support little-endian powerpc64 minidumps
rGa73e8c4f2663: libkvm: route powerpc64 minidumps to minidump backend
rG8135c7e49f39: libkvm: support little-endian powerpc64 minidumps
rG51b1272fca66: libkvm: route powerpc64 minidumps to minidump backend
rG7b8f3db50cc9: libkvm: support little-endian powerpc64 minidumps
Summary

This revision is in two commits:

libkvm: support little-endian powerpc64 minidumps

MFC after:	2 weeks
MFC to:	stable/14, stable/15
Sponsored by:	FreeBSD Foundation
libkvm: route powerpc64 minidumps to minidump backend

The regular powerpc64 core probes only checked the kernel ELF and thus
also matched minidumps.  In particular, the powerpc64le probe could
claim a minidump before the minidump backend and then reject it as an
invalid ELF core.

Exclude minidumps from both regular powerpc64 probes and add a
regression test that verifies a powerpc64le minidump reaches the
minidump parser.

Fixes:		f4eb39ba6bc9 ("[PowerPC64LE] libkvm powerpc64le support.")
MFC after:	2 weeks
MFC to:	stable/14, stable/15
Sponsored by:	FreeBSD Foundation
Test Plan

Test files are added.
LLDB can now correctly read minidumps from ppc64le QEMU.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

mchoo created this revision.Wed, Sep 16, 3:39 AM
Herald added a subscriber: imp. · View Herald TranscriptWed, Sep 16, 3:39 AM
mchoo requested review of this revision.Wed, Sep 16, 3:39 AM
Harbormaster completed remote builds in B76965: Diff 186832.Wed, Sep 16, 3:39 AM
mchoo added a reviewer: jhb.Wed, Sep 16, 3:39 AM
mchoo mentioned this in D59651: trap_cfi(9): introduce powerpc implemenation.
jhibbits accepted this revision.Thu, Sep 17, 12:52 AM
This revision is now accepted and ready to land.Thu, Sep 17, 12:52 AM
mchoo added a comment.Thu, Sep 17, 1:24 AM

ping @jhb for mentor approval

mchoo added a subscriber: olce.Fri, Sep 18, 4:03 PM

ping @olce for mentor approval

olce added a comment.Mon, Sep 28, 12:04 PM

Approved by: olce (mentor)

Closed by commit rG7b8f3db50cc9: libkvm: support little-endian powerpc64 minidumps (authored by mchoo). · Explain WhyMon, Sep 28, 3:40 PM
This revision was automatically updated to reflect the committed changes.
mchoo added a commit: rG7b8f3db50cc9: libkvm: support little-endian powerpc64 minidumps.
mchoo added a commit: rG51b1272fca66: libkvm: route powerpc64 minidumps to minidump backend.
mchoo added a commit: rG8135c7e49f39: libkvm: support little-endian powerpc64 minidumps.Mon, Oct 12, 4:00 AM
mchoo added a commit: rGa73e8c4f2663: libkvm: route powerpc64 minidumps to minidump backend.
mchoo added a commit: rGea3004b24770: libkvm: support little-endian powerpc64 minidumps.
mchoo added a commit: rG382f26f264bd: libkvm: route powerpc64 minidumps to minidump backend.

Revision Contents
Changeset List

Diff 187883

View Options

lib/libkvm/kvm_minidump_powerpc64.c

Loading...
View Options

lib/libkvm/kvm_minidump_powerpc64_hpt.c

Loading...