Paths

Table of Contentst

cxgbe: convert to timer_setup() LinuxKPI
AbandonedPublic
Actions

Authored by bz on Tue, Sep 15, 1:32 AM.

Details

Reviewers

np
jhb

Commits

rG05057380ca39: iw_cxgbe: Miscellaneous changes from the iw_cxgb4 driver

Summary

Switch from init_timer() and manual setup of structure fields, right
past setup_timer and timer_from directly to timer_setup and
timer_container_of as part of trying to clear up the Linux pre-4.15
timer KPI from LinuxKPI.

The 2nd timer I am not sure about but it seems unused?

MFC after: 3 days

Test Plan

I HAVE NOT TESTED

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 76913
Build 73796: arc lint + arc unit

Event Timeline

bz created this revision.Tue, Sep 15, 1:32 AM

Herald added subscribers: ae, imp. · View Herald TranscriptTue, Sep 15, 1:32 AM

bz requested review of this revision.Tue, Sep 15, 1:32 AM

Harbormaster completed remote builds in B76913: Diff 186743.Tue, Sep 15, 1:32 AM

bz added a parent revision: D58834: LinuxKPI: rework struct timer_list (*function[_415]).Tue, Sep 15, 1:34 AM

bz added a child revision: D59688: LinuxKPI: remove timer KPI from Linux version before 4.15.

emaste added a subscriber: emaste.Tue, Sep 15, 3:20 PM

emaste added inline comments.

sys/dev/cxgbe/iw_cxgbe/qp.c
1888–1890	why this rather than just removing `init_timer`?

superseded by 05057380ca392b29d33a4d362936e8af81101685 I believe

bz added inline comments.Tue, Sep 15, 6:00 PM

sys/dev/cxgbe/iw_cxgbe/qp.c
1888–1890	For @np and @jhb to check that it is so, as they understand the underlying data structures and events hopefully better than me. I was just wondering why it was there in first place.

Superseeded by @jhb's work. Thanks a lot!

Revision Contents
Changeset List

Path

Size

sys/

dev/

cxgbe/

iw_cxgbe/

cm.c

12 lines

qp.c

2 lines

Diff 186743

View Options

sys/dev/cxgbe/iw_cxgbe/cm.c