stand: ufs directory corruption sanity checks
AcceptedPublic
Actions

Authored by rlibby on Thu, Sep 3, 11:32 PM.

Details

Reviewers

manu
mckusick
jhb
imp
dab

Summary

Add sanity checks for corrupt UFS directory blocks. Don't allow bad
data to cause buffer overflows or infinite loops.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 77459
Build 74342: arc lint + arc unit

Event Timeline

rlibby created this revision.Thu, Sep 3, 11:32 PM

Herald added a reviewer: manu. · View Herald TranscriptThu, Sep 3, 11:32 PM

Herald added subscribers: dab, imp. · View Herald Transcript

rlibby requested review of this revision.Thu, Sep 3, 11:32 PM

Harbormaster completed remote builds in B76475: Diff 185782.Thu, Sep 3, 11:32 PM

rlibby added a reviewer: mckusick.Thu, Sep 3, 11:34 PM

rlibby mentioned this in D59379: stand: check for short reads in ufs.Tue, Sep 29, 1:30 AM

rlibby added reviewers: jhb, imp.

imp accepted this revision.Tue, Sep 29, 2:49 AM

This revision is now accepted and ready to land.Tue, Sep 29, 2:49 AM

imp added inline comments.Tue, Sep 29, 2:50 AM

stand/libsa/ufs.c
81	Neither of these is needed since they just are wrappers around stand.h

imp: rely on stand.h for string.h and strings.h

This revision now requires review to proceed.Tue, Sep 29, 4:16 PM

Harbormaster completed remote builds in B77459: Diff 188069.Tue, Sep 29, 4:16 PM

dab accepted this revision.Wed, Sep 30, 2:26 AM

This revision is now accepted and ready to land.Wed, Sep 30, 2:26 AM

Revision Contents
Changeset List

Path

Size

stand/

libsa/

ufs.c

14 lines

Diff 188069

View Options

stand: ufs directory corruption sanity checksAcceptedPublicActions