Page MenuHomeFreeBSD

amd64, powerpc: Enable tpm(4) in supported kernels
AcceptedPublic

Authored by kbowling on Fri, Aug 28, 1:59 AM.
Tags
None
Referenced Files
F169354215: D59247.diff
Tue, Sep 1, 7:20 AM
F169258058: D59247.diff
Tue, Sep 1, 2:06 AM
Unknown Object (File)
Sun, Aug 30, 4:52 PM
Unknown Object (File)
Sun, Aug 30, 8:48 AM
Unknown Object (File)
Sun, Aug 30, 7:47 AM
Unknown Object (File)
Sun, Aug 30, 7:26 AM
Unknown Object (File)
Fri, Aug 28, 12:42 PM
Unknown Object (File)
Fri, Aug 28, 12:22 PM
Subscribers

Details

Reviewers
markj
kevans
seuros
Group Reviewers
PowerPC
Summary
tpm(4) was removed from amd64 GENERIC because it broke suspend and
resume.  The preceding lifecycle, state-save, interrupt, locality, and
teardown fixes address those failures for both TPM 1.2 and TPM 2.0.

Restore the driver to amd64 GENERIC and MINIMAL, where TPM entropy
harvesting remained enabled.  Enable the driver and entropy harvesting
in the MPC85XX and QORIQ64 configurations, which already provide FDT,
spibus, and the platform SPI controller required by FDT-attached TPMs.
Leave the generic AIM and POWER configurations unchanged because they
have no TPM attachment bus.

The TPM 1.2 path completed repeated S3 cycles and command tests on
ThinkPad T430 and T440p systems.  The TPM 2.0 path completed repeated
device and full-system suspend/resume cycles on a ThinkPad P51.  The
PowerPC configuration matrix was checked to retain tpm(4) only where its
FDT SPI attachment path is present.

PR:             291067
Fixes:          16f8ea6a81b5 ("amd64: Remove tpm(4) from GENERIC for now")
MFC after:      1 month
Relnotes:       yes

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

I was a little torn when it went into GENERIC the first time, but moving into a world where we can reliably do more interesting things with various PCR measurements (which I did see your review for, but haven't had time to get back to it) I think it's a solid addition.

This revision is now accepted and ready to land.Sat, Aug 29, 3:30 AM