Page MenuHomeFreeBSD

zio: align use of "no dump" flag between use_uma and !use_uma cases
ClosedPublic

Authored by avg on Apr 9 2016, 1:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 1 2024, 6:57 PM
Unknown Object (File)
Sep 30 2024, 9:32 PM
Unknown Object (File)
Sep 30 2024, 2:52 PM
Unknown Object (File)
Sep 27 2024, 3:29 PM
Unknown Object (File)
Sep 26 2024, 6:52 PM
Unknown Object (File)
Sep 26 2024, 7:16 AM
Unknown Object (File)
Sep 25 2024, 9:16 PM
Unknown Object (File)
Sep 23 2024, 4:38 AM
Subscribers

Details

Summary

At the moment no ZFS buffers are included into a crash dump unless
ZFS_DEBUG (or INVARIANTS) kernel option is enabled. That's not very
helpful for debugging of ZFS problems, because important information
often resides in metadata buffers.
This change switches the dumping behavior when UMA is used from the
illumos behavior to a more useful behavior that we have on FreeBSD
when ZFS buffers are allocated via malloc.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avg retitled this revision from to zio: align use of "no dump" flag between use_uma and !use_uma cases.
avg updated this object.
avg edited the test plan for this revision. (Show Details)
avg added reviewers: mav, smh, will.
smh edited edge metadata.

Nice, do you have metrics on the typical dump size increase?

This revision is now accepted and ready to land.Apr 9 2016, 5:15 PM
mav edited edge metadata.

Looks good to me.

In D5892#125754, @smh wrote:

Nice, do you have metrics on the typical dump size increase?

Unfortunately, no. I've never configured a system that wouldn't dump meta-data buffers.
In any case a size of a dump should never become larger than a RAM size :-)

This revision was automatically updated to reflect the committed changes.