Page MenuHomeFreeBSD
Differential D5892

zio: align use of "no dump" flag between use_uma and !use_uma cases
ClosedPublic
Actions

Authored by avg on Apr 9 2016, 1:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 22 2024, 11:41 PM
Unknown Object (File)
Dec 20 2023, 1:20 AM
Unknown Object (File)
Dec 10 2023, 8:05 AM
Unknown Object (File)
Dec 2 2023, 10:58 AM
Unknown Object (File)
Aug 17 2023, 10:25 PM
Unknown Object (File)
Jul 3 2023, 5:40 AM
Unknown Object (File)
Jun 19 2023, 10:15 PM
Unknown Object (File)
Apr 8 2023, 9:11 PM
View All 30 Files
Subscribers
delphij
imp

Details

Reviewers
will
mav
smh
Commits
rS297812: zio: align use of "no dump" flag between use_uma and !use_uma cases
Summary

At the moment no ZFS buffers are included into a crash dump unless
ZFS_DEBUG (or INVARIANTS) kernel option is enabled. That's not very
helpful for debugging of ZFS problems, because important information
often resides in metadata buffers.
This change switches the dumping behavior when UMA is used from the
illumos behavior to a more useful behavior that we have on FreeBSD
when ZFS buffers are allocated via malloc.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

avg updated this revision to Diff 15038.Apr 9 2016, 1:03 PM
avg retitled this revision from to zio: align use of "no dump" flag between use_uma and !use_uma cases.
avg updated this object.
avg edited the test plan for this revision. (Show Details)
avg added reviewers: mav, smh, will.
Herald added subscribers: delphij, imp. · View Herald TranscriptApr 9 2016, 1:03 PM
smh accepted this revision.Apr 9 2016, 5:15 PM
smh edited edge metadata.

Nice, do you have metrics on the typical dump size increase?

This revision is now accepted and ready to land.Apr 9 2016, 5:15 PM
mav accepted this revision.Apr 9 2016, 5:23 PM
mav edited edge metadata.

Looks good to me.

avg added a comment.Apr 10 2016, 7:14 AM
In D5892#125754, @smh wrote:

Nice, do you have metrics on the typical dump size increase?

Unfortunately, no. I've never configured a system that wouldn't dump meta-data buffers.
In any case a size of a dump should never become larger than a RAM size :-)

Closed by commit rS297812: zio: align use of "no dump" flag between use_uma and !use_uma cases (authored by avg). · Explain WhyApr 11 2016, 7:11 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
cddl/
contrib/
opensolaris/
uts/
common/
fs/
zfs/
4 lines

Diff 15064

View Options

head/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/zio.c

Loading...