Increase the default mlock limit from 64k to 256k
ClosedPublic
Actions

Authored by asomers on Wed, Aug 12, 11:37 PM.

Details

Reviewers

cy
imp
jhb
emaste
markj

Commits

rGd9cf2a867184: Increase the default mlock limit from 64k to 256k

Summary

The current default has been unchanged for 14 years. Increase it to
keep pace with modern hardware and software. security/pinentry-gnome,
in particular, can sometimes need 112 kB.

PR: 297452
MFC after: 2 weeks
Sponsored by: ConnectWise

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.Wed, Aug 12, 11:37 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Aug 12, 11:37 PM

asomers requested review of this revision.Wed, Aug 12, 11:37 PM

Herald added a subscriber: andrew_tao173.riddles.org.uk. · View Herald TranscriptWed, Aug 12, 11:37 PM

Harbormaster completed remote builds in B75542: Diff 183953.Wed, Aug 12, 11:37 PM

I see no problem with this. What do others think?

This revision is now accepted and ready to land.Thu, Aug 13, 3:20 PM

I think Linux in-kernel default is 8MB, not sure if they have a separate lower limit equivalent to this. But I think increasing it a bit is fine if there are common-enough ports that want more than the current small 64K.

Closed by commit rGd9cf2a867184: Increase the default mlock limit from 64k to 256k (authored by asomers). · Explain WhyFri, Aug 14, 2:33 PM

This revision was automatically updated to reflect the committed changes.

asomers added a commit: rGd9cf2a867184: Increase the default mlock limit from 64k to 256k.

Revision Contents
Changeset List

Path

Size

usr.bin/

2 lines

Diff 184045

View Options

Increase the default mlock limit from 64k to 256kClosedPublicActions