Page MenuHomeFreeBSD
Differential D5873

Fix symbol redefinition when MFS is being used
ClosedPublic
Actions

Authored by wma on Apr 7 2016, 9:02 AM.
Tags
None
Referenced Files
F106099671: D5873.diff
Wed, Dec 25, 9:43 AM
Unknown Object (File)
Mon, Dec 9, 11:21 AM
Unknown Object (File)
Oct 18 2024, 3:07 AM
Unknown Object (File)
Oct 1 2024, 1:14 PM
Unknown Object (File)
Sep 26 2024, 4:49 AM
Unknown Object (File)
Sep 24 2024, 6:55 AM
Unknown Object (File)
Sep 24 2024, 2:20 AM
Unknown Object (File)
Sep 21 2024, 3:57 AM
View All 79 Files
Subscribers
emaste
imp

Details

Reviewers
zbb
• hselasky
marcel
bdrewery
Commits
rS298357: Fix MFS symbol redefinition with clang 3.8.0
Summary

Newest CLANG uses different name parsing. Modify regexp to match (i.e. avoid substitution of "/" or "-" with "_").

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

wma updated this revision to Diff 14969.Apr 7 2016, 9:02 AM
wma retitled this revision from to Fix symbol redefinition when MFS is being used.
wma updated this object.
wma edited the test plan for this revision. (Show Details)
wma added reviewers: bdrewery, marcel, • hselasky.
wma set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptApr 7 2016, 9:02 AM
wma updated this revision to Diff 14972.Apr 7 2016, 9:08 AM

Uploading correct diff...

• hselasky edited edge metadata.Apr 7 2016, 9:14 AM

Does this change work with older clang and what about gcc?

wma added a comment.Apr 7 2016, 3:17 PM

Do we still use clang <3.8.0 or GCC to build kernel on HEAD? If yes then it'd be better to leave previous redefine-syms and add 3 new which will handle the translation for newer clang. I'll prepare a patch and upload tomorrow.

wma updated this revision to Diff 15001.Apr 8 2016, 7:04 AM
wma added a reviewer: zbb.

That will leave previous parsing intact, just add secondary options to perform proper translation on clang-3.8.0

wma added a comment.Apr 15 2016, 11:05 PM

Are there any other comments for this patch? If not, I'd like to commit it soon.

zbb accepted this revision.Apr 20 2016, 5:48 PM
zbb edited edge metadata.

I would add a comment there why we need two definitions of the same

This revision is now accepted and ready to land.Apr 20 2016, 5:48 PM
Closed by commit rS298357: Fix MFS symbol redefinition with clang 3.8.0 (authored by wma). · Explain WhyApr 20 2016, 5:55 PM
This revision was automatically updated to reflect the committed changes.
emaste added a subscriber: emaste.Apr 20 2016, 7:17 PM

This patch is actually a workaround for an elfcopy bug that is now fixed in rS298361. It should be reverted some time later on (I will probably update the ELF Tool Chain bootstrapping test at some point).

Revision Contents
Changeset List

PathSize
sys/
conf/
6 lines

Diff 15001

View Options

sys/conf/kern.post.mk

Loading...