netmap: Fix a race in kqueue registration
ClosedPublic
Actions

Authored by markj on Wed, Aug 5, 5:37 PM.

Details

Reviewers

Commits

rG6420ead539dd: netmap: Fix a race in kqueue registration
rGbe37b1e0ba79: netmap: Fix a race in kqueue registration
rG6de818285f06: netmap: Fix a race in kqueue registration

Summary

We need to acquire the netmap global lock earlier, to avoid racing with
the NETMAP_REQ_REGISTER ioctl handler.

Reported by: syzkaller

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Wed, Aug 5, 5:37 PM

Herald added a subscriber: imp. · View Herald TranscriptWed, Aug 5, 5:37 PM

markj requested review of this revision.Wed, Aug 5, 5:37 PM

Harbormaster completed remote builds in B75396: Diff 183474.Wed, Aug 5, 5:37 PM

markj added a parent revision: D58676: netmap: Fix driver name handling.Wed, Aug 5, 5:37 PM

markj added a child revision: D58678: netmap: Handle overflow when computing ring sizes.

Looks good, thanks

This revision is now accepted and ready to land.Thu, Aug 6, 7:13 AM

Closed by commit rG6de818285f06: netmap: Fix a race in kqueue registration (authored by markj). · Explain WhyFri, Aug 7, 4:30 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG6de818285f06: netmap: Fix a race in kqueue registration.

markj added a commit: rGbe37b1e0ba79: netmap: Fix a race in kqueue registration.Mon, Aug 24, 4:30 PM

markj added a commit: rG6420ead539dd: netmap: Fix a race in kqueue registration.Mon, Aug 24, 6:49 PM

Revision Contents
Changeset List

Path

Size

sys/

dev/

netmap/

netmap_freebsd.c

12 lines

Diff 183629

View Options

sys/dev/netmap/netmap_freebsd.c

netmap: Fix a race in kqueue registrationClosedPublicActions