Page MenuHomeFreeBSD
Differential D58494

m4: Const correctness for C23
ClosedPublic
Actions

Authored by ivy on Jul 27 2026, 10:48 PM.
Tags
None
Referenced Files
F168752702: D58494.diff
Sat, Aug 29, 11:32 PM
F168729125: D58494.diff
Sat, Aug 29, 8:39 PM
Unknown Object (File)
Fri, Aug 28, 10:02 PM
Unknown Object (File)
Fri, Aug 28, 6:30 AM
Unknown Object (File)
Thu, Aug 27, 5:12 AM
Unknown Object (File)
Sat, Aug 22, 7:44 AM
Unknown Object (File)
Sat, Aug 22, 7:40 AM
Unknown Object (File)
Wed, Aug 19, 9:59 PM
View All 33 Files
Subscribers
imp

Details

Reviewers
bapt
des
dim
kevans
Commits
rG4f5673b8aeb4: m4: Const correctness for C23
rG1d94e2e0f2ee: m4: Const correctness for C23
Summary

On some platforms, e.g. Linux Clang 22.1.8 / glibc 2.43, strchr()
now implements the C23 behaviour where passing a const pointer to
strchr() also returns a const pointer. This breaks m4 during the
bootstrap build, since it assumes the return value is always a
mutable pointer.

Since the returned value is never modified, simply make the
temporary const.

MFC after: 1 week
Sponsored by: The FreeBSD Foundation

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ivy created this revision.Jul 27 2026, 10:48 PM
Herald added a subscriber: imp. · View Herald TranscriptJul 27 2026, 10:48 PM
ivy requested review of this revision.Jul 27 2026, 10:48 PM
Harbormaster completed remote builds in B75189: Diff 182857.Jul 27 2026, 10:48 PM
ivy added a comment.Jul 27 2026, 11:08 PM

i've asked dlg@openbsd.org about upstreaming this.

des added a comment.Jul 28 2026, 8:24 AM
In D58494#1342118, @ivy wrote:

i've asked dlg@openbsd.org about upstreaming this.

The upstream maintainer is espie at openbsd.

dim accepted this revision.Jul 28 2026, 5:25 PM

LGTM

This revision is now accepted and ready to land.Jul 28 2026, 5:25 PM
bapt accepted this revision.Jul 28 2026, 6:44 PM
Closed by commit rG1d94e2e0f2ee: m4: Const correctness for C23 (authored by ivy). · Explain WhyMon, Aug 3, 2:31 PM
This revision was automatically updated to reflect the committed changes.
ivy added a commit: rG1d94e2e0f2ee: m4: Const correctness for C23.
ivy added a commit: rG4f5673b8aeb4: m4: Const correctness for C23.Wed, Aug 26, 10:13 AM

Revision Contents
Changeset List

PathSize
usr.bin/
m4/
2 lines

Diff 183310

View Options

usr.bin/m4/misc.c

Loading...