firewire: remove dead code across the subsystem

[guest-seuros]

Test Plan

The code was either active or inactive. No functional change.

[adrian]

I'll think about this a bit more tomorrow. A lot of dead code is just dead code, but I do wonder what the #if 0 register programming was trying to do and what weird issues happened twenty years ago :P

sys/dev/firewire/fwcrom.c

320

oh god this code predates sbuf doesn'it it? aiee

sys/dev/firewire/fwohci.c

2525

Whats the difference between normal and short bus reset?

sys/dev/firewire/fwohci_pci.c

209

isn't this just setting then clearing MWRICEN? Maybe just leave a comment in there that MWRICEN is disabled due to broken hw

sys/dev/firewire/sbp.c

2226–2227

ok, but .. yeah we will have to figure out how to stop this from just getting in a constant loop or hanging at some point?

[guest-seuros]

sys/dev/firewire/fwcrom.c

320

23-year-old code, old enough to vote, and it voted to get refactored in another diff.

sys/dev/firewire/fwohci.c

2525

Normal reset the whole bus (full probing). ISBR is a firewire addition that reset local connection.

The code works, but i never compiled in 24 years.
The spec says ISBR is faster but some card might not have handled it correctly.

Not worth opening a pandora box unless test it .

It on my todo list to revisit it once i complete my collection of all the firewire cards.

sys/dev/firewire/fwohci_pci.c

209

The comment is inlined . it was there.

sys/dev/firewire/sbp.c

2226–2227

Yes, will do it in another round with once i can test in a firewire enclosure. This is pure mechanical cleaning.