Page MenuHomeFreeBSD
Differential D58307

firewire: add warn-only CRC validation for CSR ROM directories
ClosedPublic
Actions

Authored by guest-seuros on Fri, Jul 17, 4:39 PM.
Tags
Referenced Files
F163401131: D58307.id182144.diff
Wed, Jul 22, 9:24 PM
F163345599: D58307.diff
Wed, Jul 22, 8:42 AM
Unknown Object (File)
Wed, Jul 22, 3:47 AM
Unknown Object (File)
Tue, Jul 21, 8:27 AM
Unknown Object (File)
Tue, Jul 21, 4:43 AM
Unknown Object (File)
Mon, Jul 20, 3:29 PM
Unknown Object (File)
Mon, Jul 20, 1:49 AM
Unknown Object (File)
Sun, Jul 19, 8:25 PM
Subscribers
imp

Details

Reviewers
adrian
Group Reviewers
firewire
Commits
rGd3259935f778: firewire: add warn-only CRC validation for CSR ROM directories
Summary

Implemented crom_crc_valid() helper to validate IEEE 1394 config ROM CRC-16
checksums.

Skipped root header CRC validation since csrhdr.crc_len cover the entire
ROM body which is not fully read at header parse time. Per-directory
CRC checks below catch corruption where it needed.

Test Plan

adrian

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
sys/
dev/
firewire/
15 lines
5 lines
7 lines
5 lines
1 line

Diff 182323

View Options

sys/dev/firewire/firewire.c

Loading...
View Options

sys/dev/firewire/fwcam.c

Loading...
View Options

sys/dev/firewire/fwcrom.c

Loading...
View Options

sys/dev/firewire/fwisound.c

Loading...
View Options

sys/dev/firewire/iec13213.h

Loading...