bsd.port.mk: do not define STRIP in the configure or build environments
AcceptedPublic
Actions

Authored by royger on Tue, Jun 23, 7:59 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Jul 4, 10:05 PM

	Unknown Object (File)
	Sat, Jul 4, 9:13 AM

	Unknown Object (File)
	Fri, Jul 3, 1:43 AM

	Unknown Object (File)
	Fri, Jul 3, 1:43 AM

	Unknown Object (File)
	Thu, Jul 2, 10:16 PM

	Unknown Object (File)
	Thu, Jul 2, 9:17 AM

	Unknown Object (File)
	Sun, Jun 28, 2:30 AM

	Unknown Object (File)
	Fri, Jun 26, 10:25 AM

View All 10 Files

Subscribers

None

Details

Reviewers

fuz

Group Reviewers

portmgr

Summary

STRIP has a different meaning when using bsd.lib.mk, and hence defining it as the path to the strip binary in the environment causes existing ports to break. Revert part of cb0504025c42 and define the path to the strip binary using STRIP_CMD instead of plain STRIP.

Fixes: cb0504025c42 ("bsd.port.mk: also export GNU strip when USE_BINUTILS is set")

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

royger requested review of this revision.Tue, Jun 23, 7:59 AM

royger created this revision.

royger mentioned this in D55509: bsd.port.mk: also export GNU strip when USE_BINUTILS is set.

Looks good to me. I think portmgr needs to be looped in, too.

This revision is now accepted and ready to land.Tue, Jun 23, 8:46 AM

Done, was waiting to add them to confirm you think this is the right fix.

Revision Contents
Changeset List

Path

Size

Mk/

bsd.port.mk

4 lines

Diff 180354

View Options

bsd.port.mk: do not define STRIP in the configure or build environmentsAcceptedPublicActions