uart: Add support for the Intel XScale controller
ClosedPublic
Actions

Authored by bnovkov on Thu, Jun 18, 2:43 AM.

Details

Reviewers

imp

Commits

rG1665954e508f: uart: Add support for the Intel XScale controller

Summary

The ns8250 driver avoids clearing IER bit 0x10 to account for the
split "receiver time-out interrupt enable" bit, but it never sets
it in ier_rxbits even though a comment in ns8250_init implies so.

Fix this by setting IER_RXTMOUT if we've matched an XScale uart.

Event: BSDCan 2026

Test Plan

Tested on a Banana Pi BPI-F3 SoC. Using the console without the IER_RXTMOUT changes is impossible, applying this patch fixes it.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bnovkov requested review of this revision.Thu, Jun 18, 2:43 AM

bnovkov created this revision.

Harbormaster completed remote builds in B73954: Diff 179969.Thu, Jun 18, 2:43 AM

bnovkov edited the summary of this revision. (Show Details)Thu, Jun 18, 2:47 AM

bnovkov edited the test plan for this revision. (Show Details)

imp accepted this revision.Thu, Jun 18, 7:55 PM

This revision is now accepted and ready to land.Thu, Jun 18, 7:55 PM

Closed by commit rG1665954e508f: uart: Add support for the Intel XScale controller (authored by bnovkov). · Explain WhyFri, Jun 19, 2:06 PM

This revision was automatically updated to reflect the committed changes.

bnovkov added a commit: rG1665954e508f: uart: Add support for the Intel XScale controller.

Revision Contents
Changeset List

Path

Size

sys/

dev/

uart/

uart_dev_ns8250.c

7 lines

Diff 180055

View Options

sys/dev/uart/uart_dev_ns8250.c

uart: Add support for the Intel XScale controllerClosedPublicActions