Page MenuHomeFreeBSD
Differential D57629

uart: Add support for the Intel XScale controller
ClosedPublic
Actions

Authored by bnovkov on Jun 18 2026, 2:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 15, 7:26 AM
Unknown Object (File)
Wed, Jul 15, 7:26 AM
Unknown Object (File)
Mon, Jul 13, 1:12 AM
Unknown Object (File)
Fri, Jul 10, 2:24 PM
Unknown Object (File)
Tue, Jul 7, 8:46 AM
Unknown Object (File)
Fri, Jul 3, 12:20 PM
Unknown Object (File)
Fri, Jul 3, 1:02 AM
Unknown Object (File)
Thu, Jul 2, 9:17 PM
View All 24 Files
Subscribers
None

Details

Reviewers
imp
Commits
rG1665954e508f: uart: Add support for the Intel XScale controller
Summary

The ns8250 driver avoids clearing IER bit 0x10 to account for the
split "receiver time-out interrupt enable" bit, but it never sets
it in ier_rxbits even though a comment in ns8250_init implies so.

Fix this by setting IER_RXTMOUT if we've matched an XScale uart.

Event: BSDCan 2026

Test Plan

Tested on a Banana Pi BPI-F3 SoC. Using the console without the IER_RXTMOUT changes is impossible, applying this patch fixes it.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bnovkov requested review of this revision.Jun 18 2026, 2:43 AM
bnovkov created this revision.
Harbormaster completed remote builds in B73954: Diff 179969.Jun 18 2026, 2:43 AM
bnovkov edited the summary of this revision. (Show Details)Jun 18 2026, 2:47 AM
bnovkov edited the test plan for this revision. (Show Details)
imp accepted this revision.Jun 18 2026, 7:55 PM
This revision is now accepted and ready to land.Jun 18 2026, 7:55 PM
Closed by commit rG1665954e508f: uart: Add support for the Intel XScale controller (authored by bnovkov). · Explain WhyJun 19 2026, 2:06 PM
This revision was automatically updated to reflect the committed changes.
bnovkov added a commit: rG1665954e508f: uart: Add support for the Intel XScale controller.

Revision Contents
Changeset List

PathSize
sys/
dev/
uart/
7 lines

Diff 180055

View Options

sys/dev/uart/uart_dev_ns8250.c

Loading...