Page MenuHomeFreeBSD
Differential D5745

rwlock(9): Add shared priority propagation mode
AbandonedPublic
Actions

Authored by cem on Mar 26 2016, 1:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Sep 10, 2:21 PM
Unknown Object (File)
Sun, Sep 6, 11:06 AM
Unknown Object (File)
Sun, Sep 6, 9:45 AM
Unknown Object (File)
Sat, Sep 5, 12:58 PM
Unknown Object (File)
Sat, Sep 5, 11:55 AM
Unknown Object (File)
Sat, Sep 5, 11:25 AM
Unknown Object (File)
Sat, Sep 5, 12:50 AM
Unknown Object (File)
Thu, Sep 3, 4:28 PM
View All 82 Files
Subscribers
imp
wblock

Details

Reviewers
kib
markj
jhb
Group Reviewers
manpages
Summary

Add shared priority propagation as an optional rwlock mode (default off).

All rwlocks are bloated by a pointer (32 -> 40 bytes on amd64).

Locks that opt in to shared priority propagation pass rw_priotracker structs
exactly like rmlocks.

Test Plan

The use case in mind is the PV global lock.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3140
Build 3173: arc lint + arc unit

Event Timeline

cem updated this revision to Diff 14622.Mar 26 2016, 1:43 AM
cem retitled this revision from to rwlock(9): Add shared priority propagation mode.
cem updated this object.
cem edited the test plan for this revision. (Show Details)
cem added reviewers: jhb, markj, kib.
Herald added a reviewer: manpages. · View Herald TranscriptMar 26 2016, 1:43 AM
Herald added a subscriber: imp. · View Herald Transcript
wblock added a subscriber: wblock.Mar 26 2016, 2:11 AM

Man page changes look good!

cem updated this revision to Diff 14907.Apr 6 2016, 1:59 AM
cem edited edge metadata.

Pick the oldest reader thread as owner for consistency in turnstile.

Herald edited edge metadata. · View Herald TranscriptApr 6 2016, 1:59 AM
cem abandoned this revision.Dec 23 2016, 12:00 AM

Revision Contents
Changeset List

PathSize
share/
man/
man9/
52 lines
sys/
kern/
214 lines
1 line
sys/
11 lines
1 line
31 lines

Diff 14907

View Options

share/man/man9/rwlock.9

Loading...
View Options

sys/kern/kern_rwlock.c

Loading...
View Options

sys/kern/subr_lock.c

Loading...
View Options

sys/sys/_rwlock.h

Loading...
View Options

sys/sys/lock.h

Loading...
View Options

sys/sys/rwlock.h

Loading...