Page MenuHomeFreeBSD
Differential D57332

netlink: Check permission for interface flag changes
ClosedPublic
Actions

Authored by emaste on May 29 2026, 3:53 PM.
Tags
None
Referenced Files
F163156788: D57332.diff
Mon, Jul 20, 2:46 PM
Unknown Object (File)
Wed, Jul 15, 8:39 AM
Unknown Object (File)
Wed, Jul 15, 7:24 AM
Unknown Object (File)
Wed, Jul 15, 7:24 AM
Unknown Object (File)
Wed, Jul 1, 10:41 PM
Unknown Object (File)
Tue, Jun 30, 3:46 PM
Unknown Object (File)
Tue, Jun 30, 3:08 PM
Unknown Object (File)
Tue, Jun 30, 10:07 AM
View All 32 Files
Subscribers
glebius
imp
melifaro
pouria

Details

Reviewers
bz
melifaro
pouria
Group Reviewers
network
Commits
rG30d907804d7d: netlink: Check permissions for interface flag changes
rG96dbc9a8de10: netlink: Check permissions for interface flag changes

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.May 29 2026, 3:53 PM
Herald added a reviewer: melifaro. · View Herald TranscriptMay 29 2026, 3:53 PM
Herald added subscribers: glebius, melifaro. · View Herald Transcript
emaste requested review of this revision.May 29 2026, 3:53 PM
emaste added inline comments.May 29 2026, 3:58 PM
sys/netlink/route/iface_drivers.c
71–72

I'd like to invert the sense and switch these to early exit as well

emaste updated this revision to Diff 178919.May 29 2026, 4:02 PM

also promisc

pouria accepted this revision.May 29 2026, 9:00 PM
pouria added a subscriber: pouria.
pouria added inline comments.
sys/netlink/route/iface_drivers.c
71–72

+1

This revision is now accepted and ready to land.May 29 2026, 9:00 PM
emaste mentioned this in D57349: netlink: Use early exit pattern in _nl_modify_ifp_generic.May 29 2026, 9:10 PM
melifaro accepted this revision.May 29 2026, 9:56 PM
Closed by commit rG96dbc9a8de10: netlink: Check permissions for interface flag changes (authored by emaste). · Explain WhyMay 29 2026, 11:12 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rG96dbc9a8de10: netlink: Check permissions for interface flag changes.
Herald added a subscriber: imp. · View Herald TranscriptMay 29 2026, 11:12 PM
emaste added a commit: rG30d907804d7d: netlink: Check permissions for interface flag changes.Jun 9 2026, 2:10 PM

Revision Contents
Changeset List

PathSize
sys/
netlink/
route/
11 lines

Diff 178968

View Options

sys/netlink/route/iface_drivers.c

Loading...