netlink: Check permission for interface flag changes
ClosedPublic
Actions

Authored by emaste on Fri, May 29, 3:53 PM.

Details

Reviewers

bz
melifaro
pouria

Group Reviewers

network

Commits

rG96dbc9a8de10: netlink: Check permissions for interface flag changes

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

emaste created this revision.Fri, May 29, 3:53 PM

Herald added a reviewer: melifaro. · View Herald TranscriptFri, May 29, 3:53 PM

Herald added subscribers: glebius, melifaro. · View Herald Transcript

emaste requested review of this revision.Fri, May 29, 3:53 PM

emaste added inline comments.Fri, May 29, 3:58 PM

sys/netlink/route/iface_drivers.c
71–72	I'd like to invert the sense and switch these to early exit as well

also promisc

pouria accepted this revision.Fri, May 29, 9:00 PM

pouria added a subscriber: pouria.

pouria added inline comments.

sys/netlink/route/iface_drivers.c
71–72	+1

This revision is now accepted and ready to land.Fri, May 29, 9:00 PM

emaste mentioned this in D57349: netlink: Use early exit pattern in _nl_modify_ifp_generic.Fri, May 29, 9:10 PM

melifaro accepted this revision.Fri, May 29, 9:56 PM

Closed by commit rG96dbc9a8de10: netlink: Check permissions for interface flag changes (authored by emaste). · Explain WhyFri, May 29, 11:12 PM

This revision was automatically updated to reflect the committed changes.

emaste added a commit: rG96dbc9a8de10: netlink: Check permissions for interface flag changes.

Herald added a subscriber: imp. · View Herald TranscriptFri, May 29, 11:12 PM

Revision Contents
Changeset List

Path

Size

sys/

netlink/

route/

iface_drivers.c

11 lines

Diff 178968

View Options

sys/netlink/route/iface_drivers.c

netlink: Check permission for interface flag changesClosedPublicActions