Page MenuHomeFreeBSD
Differential D57268

rtnetlink: Don't send RTA_PRIORITY if has default value
AbandonedPublic
Actions

Authored by pouria on May 27 2026, 10:58 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Aug 13, 2:27 AM
Unknown Object (File)
Mon, Aug 10, 2:26 PM
Unknown Object (File)
Sat, Aug 8, 11:41 AM
Unknown Object (File)
Sat, Aug 8, 9:32 AM
Unknown Object (File)
Sat, Aug 8, 8:39 AM
Unknown Object (File)
Sat, Aug 8, 7:14 AM
Unknown Object (File)
Fri, Aug 7, 3:09 PM
Unknown Object (File)
Fri, Aug 7, 7:24 AM
View All 35 Files
Subscribers
emaste
imp

Details

Reviewers
melifaro
glebius
markj
Group Reviewers
network
Summary

Also update route(8) and netstat(8) to show
default metric if it was not specified.
This helps reducing netlink message size.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 73473
Build 70356: arc lint + arc unit

Event Timeline

pouria created this revision.May 27 2026, 10:58 AM
Herald added a subscriber: imp. · View Herald TranscriptMay 27 2026, 10:58 AM
pouria requested review of this revision.May 27 2026, 10:58 AM
Harbormaster completed remote builds in B73473: Diff 178715.May 27 2026, 10:58 AM
emaste added a subscriber: emaste.May 29 2026, 6:08 PM
melifaro added a comment.Thu, Aug 13, 10:05 PM

I'm not sure - defaults tend to change and hardcoding those in netstat / rtsock seem somewhat fragile. Let's maybe take a step back - is there any measurable performance difference after the change?

pouria abandoned this revision.Fri, Aug 14, 6:39 AM

Revision Contents
Changeset List

PathSize
sbin/
route/
20 lines
sys/
netlink/
route/
9 lines
usr.bin/
netstat/
1 line
1 line
4 lines

Diff 178715

View Options

sbin/route/route_netlink.c

Loading...
View Options

sys/netlink/route/rt.c

Loading...
View Options

usr.bin/netstat/common.h

Loading...
View Options

usr.bin/netstat/route.c

Loading...
View Options

usr.bin/netstat/route_netlink.c

Loading...