Page MenuHomeFreeBSD
Differential D57172

netlink: Avoid potential undefined behaviour
ClosedPublic
Actions

Authored by emaste on Fri, May 22, 2:55 PM.

Details

Reviewers
des
melifaro
bz
Group Reviewers
network
Commits
rG4d125ed6e7d4: netlink: Avoid potential undefined behaviour
Summary

The KASSERT indicates that the index is guaranteed not to be OOB.

Reported by: des

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.Fri, May 22, 2:55 PM
Herald added a reviewer: melifaro. · View Herald TranscriptFri, May 22, 2:55 PM
Herald added subscribers: glebius, melifaro. · View Herald Transcript
emaste requested review of this revision.Fri, May 22, 2:55 PM
des accepted this revision.Fri, May 22, 3:24 PM

Agreed but I didn't report this, I reported something else that I now realize is a non-issue (the assignment on line 139 is ok because of the check on line 123, and the assignment on line 147 is ok because of the check on line 141)

sys/netlink/netlink_generic.c
98

You can just return this, no need for a temporary variable now.

This revision is now accepted and ready to land.Fri, May 22, 3:24 PM
emaste updated this revision to Diff 178483.Sat, May 23, 4:27 PM

just return

This revision now requires review to proceed.Sat, May 23, 4:27 PM
bz accepted this revision.Sat, May 23, 4:56 PM
This revision is now accepted and ready to land.Sat, May 23, 4:56 PM
Closed by commit rG4d125ed6e7d4: netlink: Avoid potential undefined behaviour (authored by emaste). · Explain WhySat, May 23, 11:11 PM
This revision was automatically updated to reflect the committed changes.
emaste added a commit: rG4d125ed6e7d4: netlink: Avoid potential undefined behaviour.
Herald added a subscriber: imp. · View Herald TranscriptSat, May 23, 11:11 PM

Revision Contents
Changeset List

PathSize
sys/
netlink/
8 lines

Diff 178508

View Options

sys/netlink/netlink_generic.c

Loading...