Page MenuHomeFreeBSD
Differential D57149

tests/procdesc: Use a more efficient mechanism to block
ClosedPublic
Actions

Authored by markj on Thu, May 21, 2:09 PM.

Details

Reviewers
kib
Commits
rGc9546bb61910: tests/procdesc: Use a more efficient mechanism to block

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Thu, May 21, 2:09 PM
Herald added a subscriber: imp. · View Herald TranscriptThu, May 21, 2:09 PM
markj requested review of this revision.Thu, May 21, 2:09 PM
Harbormaster completed remote builds in B73313: Diff 178316.Thu, May 21, 2:09 PM
markj added a parent revision: D57148: tests/jaildesc: Use a more efficient mechanism to block.Thu, May 21, 2:09 PM
markj added a reviewer: kib.Thu, May 21, 2:10 PM
kib accepted this revision.Thu, May 21, 2:15 PM

I would also consider adding some timeout by counting the number of usleep() calls, to avoid infinite wait.

This revision is now accepted and ready to land.Thu, May 21, 2:15 PM
markj added a comment.Thu, May 21, 2:18 PM
In D57149#1309603, @kib wrote:

I would also consider adding some timeout by counting the number of usleep() calls, to avoid infinite wait.

kyua itself provides a timeout mechanism, I think it's ok to rely on that?

kib added a comment.Thu, May 21, 2:19 PM
In D57149#1309608, @markj wrote:
In D57149#1309603, @kib wrote:

I would also consider adding some timeout by counting the number of usleep() calls, to avoid infinite wait.

kyua itself provides a timeout mechanism, I think it's ok to rely on that?

Sure.

Closed by commit rGc9546bb61910: tests/procdesc: Use a more efficient mechanism to block (authored by markj). · Explain WhyFri, May 22, 2:57 PM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGc9546bb61910: tests/procdesc: Use a more efficient mechanism to block.

Revision Contents
Changeset List

PathSize
tests/
sys/
kern/
2 lines
41 lines

Diff 178395

View Options

tests/sys/kern/Makefile

Loading...
View Options

tests/sys/kern/procdesc.c

Loading...