Differential D56745

pf: do not reject rules with colliding hashes
ClosedPublic
Actions

Authored by kp on Thu, Apr 30, 11:44 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, May 18, 1:19 AM

	Unknown Object (File)
	Mon, May 18, 1:12 AM

	Unknown Object (File)
	Sat, May 16, 11:48 PM

	Unknown Object (File)
	Sat, May 16, 10:58 PM

	Unknown Object (File)
	Fri, May 15, 10:34 PM

	Unknown Object (File)
	Fri, May 15, 8:59 PM

	Unknown Object (File)
	Fri, May 15, 1:21 PM

	Unknown Object (File)
	Thu, May 14, 1:47 AM

View All 21 Files

Subscribers

vegeta_tuxpowered.net

Details

Reviewers

Group Reviewers

pfsense
network

Commits

rG0cd655f71b46: pf: do not reject rules with colliding hashes
rGfab9bfc92751: pf: do not reject rules with colliding hashes
rGa0e4c65f1814: pf: do not reject rules with colliding hashes

Summary

We insert rules in pf_krule_global solely for the benefit of the
'keepcounters' feature. Failing to insert (beause the rule hash
collides, or an identical rule already exists) would be worse than
restoring counts to the wrong rule (or failing to restore them at all).

PR: 282863, 294860, 294859, 294858
MFC after: 3 days
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kp created this revision.Thu, Apr 30, 11:44 AM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptThu, Apr 30, 11:44 AM

kp requested review of this revision.Thu, Apr 30, 11:44 AM

Harbormaster completed remote builds in B72667: Diff 176896.Thu, Apr 30, 11:44 AM

This revision was not accepted when it landed; it landed in state Needs Review.Tue, May 5, 9:26 PM

Closed by commit rGa0e4c65f1814: pf: do not reject rules with colliding hashes (authored by kp). · Explain Why

This revision was automatically updated to reflect the committed changes.

kp added a commit: rGa0e4c65f1814: pf: do not reject rules with colliding hashes.

kp added a commit: rG0cd655f71b46: pf: do not reject rules with colliding hashes.Sat, May 9, 1:31 PM

kp added a commit: rGfab9bfc92751: pf: do not reject rules with colliding hashes.

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

24 lines

tests/

sys/

netpfil/

pf/

36 lines

Diff 177273

sys/netpfil/pf/pf_ioctl.c

Loading...

tests/sys/netpfil/pf/match.sh

Loading...