Page MenuHomeFreeBSD

pf: do not reject rules with colliding hashes
Needs ReviewPublic

Authored by kp on Thu, Apr 30, 11:44 AM.

Details

Reviewers
mjg
Group Reviewers
pfsense
network
Summary

We insert rules in pf_krule_global solely for the benefit of the
'keepcounters' feature. Failing to insert (beause the rule hash
collides, or an identical rule already exists) would be worse than
restoring counts to the wrong rule (or failing to restore them at all).

PR: 282863, 294860, 294859, 294858
MFC after: 3 days
Sponsored by: Rubicon Communications, LLC ("Netgate")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 72667
Build 69550: arc lint + arc unit