Page MenuHomeFreeBSD
Differential D56722

lockf: Avoid spinning when operating on an fd
ClosedPublic
Actions

Authored by des on Apr 29 2026, 10:50 PM.
Tags
None
Referenced Files
F160423265: D56722.diff
Wed, Jun 24, 7:52 AM
Unknown Object (File)
Fri, Jun 5, 9:23 PM
Unknown Object (File)
Mon, Jun 1, 11:31 PM
Unknown Object (File)
Mon, Jun 1, 11:25 PM
Unknown Object (File)
Mon, Jun 1, 1:17 PM
Unknown Object (File)
Mon, Jun 1, 1:12 PM
Unknown Object (File)
Mon, Jun 1, 12:33 PM
Unknown Object (File)
Mon, Jun 1, 12:23 PM
View All 37 Files
Subscribers
imp
markj

Details

Reviewers
kevans
markj
Commits
rGd0f618e7ae95: lockf: Avoid spinning when operating on an fd
rG651b82e64ef4: lockf: Avoid spinning when operating on an fd
rG4a6c4f0265ac: lockf: Avoid spinning when operating on an fd
rG2052d09b7a5f: lockf: Avoid spinning when operating on an fd
rGd90513ea8569: lockf: Avoid spinning when operating on an fd
Summary

When operating on a file descriptor, acquire_lock() would ignore the
flags argument and always operate in non-blocking mode, resulting in
unnecessary busy-looping.

PR: 294832
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des created this revision.Apr 29 2026, 10:50 PM
Herald added a subscriber: imp. · View Herald TranscriptApr 29 2026, 10:50 PM
des requested review of this revision.Apr 29 2026, 10:50 PM
Harbormaster completed remote builds in B72645: Diff 176831.Apr 29 2026, 10:50 PM
des added a child revision: D56723: lockf: Test that lockf does not spin on fd.Apr 29 2026, 10:51 PM
markj accepted this revision.May 2 2026, 5:28 PM
markj added a subscriber: markj.
markj added inline comments.
usr.bin/lockf/lockf.c
322–324

Better would be to declare lflags in this block, it's only used there.

This revision is now accepted and ready to land.May 2 2026, 5:28 PM
des updated this revision to Diff 177050.May 2 2026, 6:52 PM

rf

This revision now requires review to proceed.May 2 2026, 6:52 PM
Harbormaster completed remote builds in B72727: Diff 177050.May 2 2026, 6:52 PM
markj accepted this revision.May 3 2026, 3:25 PM
This revision is now accepted and ready to land.May 3 2026, 3:25 PM
Closed by commit rGd90513ea8569: lockf: Avoid spinning when operating on an fd (authored by Christian Ullrich <chris@chrullrich.net>, committed by des). · Explain WhyMay 3 2026, 3:35 PM
This revision was automatically updated to reflect the committed changes.
des added a commit: rGd90513ea8569: lockf: Avoid spinning when operating on an fd.
des added a commit: rG2052d09b7a5f: lockf: Avoid spinning when operating on an fd.May 6 2026, 5:38 AM
des added a commit: rG4a6c4f0265ac: lockf: Avoid spinning when operating on an fd.
des added a commit: rG651b82e64ef4: lockf: Avoid spinning when operating on an fd.
cperciva added a commit: rGd0f618e7ae95: lockf: Avoid spinning when operating on an fd.May 6 2026, 4:31 PM

Revision Contents
Changeset List

PathSize
usr.bin/
lockf/
6 lines

Diff 177072

View Options

usr.bin/lockf/lockf.c

Loading...