ident: Clean up
ClosedPublic
Actions

Authored by des on Sat, Apr 18, 4:17 PM.

Details

Reviewers

bapt
ngie

Group Reviewers

tests
manpages

Commits

rG394f6b1b0a65: ident: Clean up

Summary

MFC after: 1 week

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

des requested review of this revision.Sat, Apr 18, 4:17 PM

ngie added a subscriber: ngie.

ngie added inline comments.

usr.bin/ident/tests/ident_test.sh
55–57	This avoids the need for duplicate redirects to `out`.
78	Why pipe this to `true`?

This revision is now accepted and ready to land.Tue, Apr 21, 4:40 AM

des marked an inline comment as done.Tue, Apr 21, 6:05 AM

des added inline comments.

usr.bin/ident/tests/ident_test.sh
78	To cause a write failure.

des marked an inline comment as done.Tue, Apr 21, 6:05 AM

This revision was automatically updated to reflect the committed changes.

usr.bin/ident/tests/ident_test.sh
78	Adding a comment around/to this line and the other corresponding lines in D56506 would help readers that don't understand the intent and don't have access to the Differential. It wasn't obvious to me what the intent was - I bet others might be confused as well.

usr.bin/ident/tests/ident_test.sh
78	The test case already has a description which explains what it tests, and is identical or nearly so half a dozen similarly-named test cases going back years (I think asa was the first one).