Page MenuHomeFreeBSD

iwx: Fix 32-bit compilation
ClosedPublic

Authored by olce on Thu, Mar 5, 1:04 PM.
Tags
None
Referenced Files
F147287461: D55667.diff
Mon, Mar 9, 5:15 PM
Unknown Object (File)
Sun, Mar 8, 7:59 AM
Unknown Object (File)
Sat, Mar 7, 8:05 AM
Unknown Object (File)
Sat, Mar 7, 1:04 AM
Unknown Object (File)
Sat, Mar 7, 1:03 AM
Unknown Object (File)
Sat, Mar 7, 1:01 AM
Subscribers

Details

Summary
  • Avoid shifts wider than integer types, by wrapping the corresponding checks into '#if SIZEOF_SIZE_T > 32' blocks. 'bus_addr_t' has the same width as 'size_t' on all architectures (and this is not going to change for 32-bit architectures).
  • Use appropriate printf(3) format for 'wk_keytsc'.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

olce requested review of this revision.Thu, Mar 5, 1:04 PM

(Alternative: Don't compile this on 32-bit architectures at all, if if_iwx in reality does not support those.)

(Alternative: Don't compile this on 32-bit architectures at all, if if_iwx in reality does not support those.)

it doesn't? what about it doesn't support 32 bit archs?

adrian added inline comments.
sys/dev/iwx/if_iwx.c
5821

ugh if this is a hardware limitation then god i wish we could describe it somehow to busdma...

This revision is now accepted and ready to land.Thu, Mar 5, 4:07 PM
This revision was automatically updated to reflect the committed changes.
olce marked an inline comment as done.