Tiny manpage bug I caused in D50241
I left a line in the manpage that shouldn't be there.
Details
Details
# man ngctl | head -8
NGCTL(8) FreeBSD System Manager's Manual NGCTL(8)
NAME
ngctl – netgraph control utility
SYNOPSIS
ngctl [-j jail] [-d] [-f filename] [-n nodename] [command [argument ...]]
[command ...]That last [command ...] on its own line should not be there. It should match usage from ngctl.
Diff Detail
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
The usage is, I believe, correct:
# ngctl -h ngctl: illegal option -- h usage: ngctl [-j jail] [-d] [-f filename] [-n nodename] [command [argument ...]]
That is you can issue exactly one command with many arguments. If you want multiple commands you must use a file.
| usr.sbin/ngctl/main.c | ||
|---|---|---|
| 255 ↗ | (On Diff #172581) | Damn, I thought getline() returned 0 on EOF. So there are two bugs here: the loop condition should use >= instead of >, and this if should just check ferror(fp). |
Comment Actions
As @des has the correct fix for ngctl, I'm going to just going to update this to have my manpage bug. Thanks!