Page MenuHomeFreeBSD

ngctl: Fix getline loop
ClosedPublic

Authored by des on Feb 24 2026, 2:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Aug 3, 7:52 AM
Unknown Object (File)
Mon, Aug 3, 4:51 AM
Unknown Object (File)
Sun, Aug 2, 6:23 AM
Unknown Object (File)
Thu, Jul 30, 3:53 PM
Unknown Object (File)
Tue, Jul 28, 3:28 PM
Unknown Object (File)
Mon, Jul 27, 9:17 AM
Unknown Object (File)
Sun, Jul 26, 11:53 AM
Unknown Object (File)
Sat, Jul 25, 5:20 AM

Details

Summary

I misremembered when I wrote this code: getline() returns -1 on EOF, not
zero, so the loop condition and the error check are both incorrect.

MFC after: 3 days
Fixes: 3cbdcabf714d ("ngctl: Modernize code somewhat")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable