Page MenuHomeFreeBSD

ngctl: Fix getline loop
ClosedPublic

Authored by des on Feb 24 2026, 2:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 18, 8:42 AM
Unknown Object (File)
Sat, Sep 12, 7:45 AM
Unknown Object (File)
Fri, Sep 11, 4:29 AM
Unknown Object (File)
Thu, Sep 10, 9:06 AM
Unknown Object (File)
Sun, Sep 6, 2:46 PM
Unknown Object (File)
Sun, Sep 6, 2:44 PM
Unknown Object (File)
Sun, Sep 6, 10:27 AM
Unknown Object (File)
Sun, Sep 6, 12:03 AM

Details

Summary

I misremembered when I wrote this code: getline() returns -1 on EOF, not
zero, so the loop condition and the error check are both incorrect.

MFC after: 3 days
Fixes: 3cbdcabf714d ("ngctl: Modernize code somewhat")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable