Page MenuHomeFreeBSD

ngctl: Fix getline loop
ClosedPublic

Authored by des on Feb 24 2026, 2:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 7, 2:12 AM
Unknown Object (File)
Tue, Jul 7, 1:14 AM
Unknown Object (File)
Sun, Jun 28, 5:57 AM
Unknown Object (File)
Tue, Jun 23, 12:19 AM
Unknown Object (File)
Tue, Jun 16, 8:27 AM
Unknown Object (File)
Jun 6 2026, 8:26 AM
Unknown Object (File)
Jun 5 2026, 11:26 PM
Unknown Object (File)
Jun 5 2026, 7:12 PM

Details

Summary

I misremembered when I wrote this code: getline() returns -1 on EOF, not
zero, so the loop condition and the error check are both incorrect.

MFC after: 3 days
Fixes: 3cbdcabf714d ("ngctl: Modernize code somewhat")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable