Page MenuHomeFreeBSD

ngctl: Fix getline loop
ClosedPublic

Authored by des on Feb 24 2026, 2:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 14, 3:57 PM
Unknown Object (File)
Mon, Mar 9, 8:08 PM
Unknown Object (File)
Mon, Mar 9, 8:08 PM
Unknown Object (File)
Sun, Mar 8, 8:22 PM
Unknown Object (File)
Tue, Mar 3, 11:58 PM
Unknown Object (File)
Feb 26 2026, 3:55 AM
Unknown Object (File)
Feb 25 2026, 7:41 PM
Unknown Object (File)
Feb 25 2026, 4:10 PM

Details

Summary

I misremembered when I wrote this code: getline() returns -1 on EOF, not
zero, so the loop condition and the error check are both incorrect.

MFC after: 3 days
Fixes: 3cbdcabf714d ("ngctl: Modernize code somewhat")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable