Page MenuHomeFreeBSD

ngctl: Fix getline loop
ClosedPublic

Authored by des on Feb 24 2026, 2:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 16, 8:27 AM
Unknown Object (File)
Sat, Jun 6, 8:26 AM
Unknown Object (File)
Fri, Jun 5, 11:26 PM
Unknown Object (File)
Fri, Jun 5, 7:12 PM
Unknown Object (File)
Thu, Jun 4, 10:36 PM
Unknown Object (File)
May 16 2026, 11:43 PM
Unknown Object (File)
May 14 2026, 3:52 AM
Unknown Object (File)
May 10 2026, 2:18 PM

Details

Summary

I misremembered when I wrote this code: getline() returns -1 on EOF, not
zero, so the loop condition and the error check are both incorrect.

MFC after: 3 days
Fixes: 3cbdcabf714d ("ngctl: Modernize code somewhat")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable