Page MenuHomeFreeBSD

ngctl: Fix getline loop
ClosedPublic

Authored by des on Feb 24 2026, 2:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 16, 11:43 PM
Unknown Object (File)
Thu, May 14, 3:52 AM
Unknown Object (File)
Sun, May 10, 2:18 PM
Unknown Object (File)
Sun, May 10, 2:12 PM
Unknown Object (File)
Tue, Apr 28, 4:20 PM
Unknown Object (File)
Tue, Apr 28, 4:12 PM
Unknown Object (File)
Mon, Apr 27, 5:55 AM
Unknown Object (File)
Tue, Apr 21, 2:05 PM

Details

Summary

I misremembered when I wrote this code: getline() returns -1 on EOF, not
zero, so the loop condition and the error check are both incorrect.

MFC after: 3 days
Fixes: 3cbdcabf714d ("ngctl: Modernize code somewhat")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable