Page MenuHomeFreeBSD

ngctl: Fix getline loop
ClosedPublic

Authored by des on Feb 24 2026, 2:14 PM.
Tags
None
Referenced Files
F168109155: D55487.id172591.diff
Wed, Aug 26, 10:37 AM
Unknown Object (File)
Wed, Aug 12, 12:37 AM
Unknown Object (File)
Tue, Aug 11, 2:15 AM
Unknown Object (File)
Mon, Aug 10, 9:04 PM
Unknown Object (File)
Mon, Aug 10, 10:06 AM
Unknown Object (File)
Sun, Aug 9, 7:48 PM
Unknown Object (File)
Sun, Aug 9, 7:09 AM
Unknown Object (File)
Sat, Aug 8, 5:42 PM

Details

Summary

I misremembered when I wrote this code: getline() returns -1 on EOF, not
zero, so the loop condition and the error check are both incorrect.

MFC after: 3 days
Fixes: 3cbdcabf714d ("ngctl: Modernize code somewhat")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable